]> git.proxmox.com Git - mirror_qemu.git/commitdiff
hw/pci-host/Kconfig: Add missing dependency MV64361 -> I8259
authorPhilippe Mathieu-Daudé <f4bug@amsat.org>
Fri, 14 May 2021 09:44:34 +0000 (11:44 +0200)
committerPhilippe Mathieu-Daudé <philmd@redhat.com>
Tue, 20 Jul 2021 18:10:03 +0000 (20:10 +0200)
Looking at the MV64341 model source, there is a dependency on the
8259 interrupt controller:

  523     case MV64340_PCI_1_INTERRUPT_ACKNOWLEDGE_VIRTUAL_REG:
  524         /* FIXME: Should this be sent via the PCI bus somehow? */
  525         if (s->gpp_int_level && (s->gpp_value & BIT(31))) {
  526             ret = pic_read_irq(isa_pic);
  527         }
  528         break;

Add it to Kconfig to avoid the following build failure:

  /usr/bin/ld: libcommon.fa.p/hw_pci-host_mv64361.c.o: in function `mv64361_read':
  hw/pci-host/mv64361.c:526: undefined reference to `isa_pic'
  /usr/bin/ld: hw/pci-host/mv64361.c:526: undefined reference to `pic_read_irq'

Fixes: dcdf98a9015 ("hw/pci-host: Add emulation of Marvell MV64361 PPC system controller")
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Acked-by: David Gibson <david@gibson.dropbear.id.au>
Message-Id: <20210515173716.358295-10-philmd@redhat.com>

hw/pci-host/Kconfig

index 84494400b86e95be0f9a626b7af240c7cd09b2f2..2b5f7d58cc5d5d854731f19abf58a3f534b03ff7 100644 (file)
@@ -76,3 +76,4 @@ config SH_PCI
 config MV64361
     bool
     select PCI
+    select I8259