]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commitdiff
media: allegro: fix type of gop_length in channel_create message
authorMichael Tretter <m.tretter@pengutronix.de>
Mon, 16 Mar 2020 15:26:23 +0000 (16:26 +0100)
committerStefan Bader <stefan.bader@canonical.com>
Tue, 5 May 2020 10:32:22 +0000 (12:32 +0200)
BugLink: https://bugs.launchpad.net/bugs/1873481
[ Upstream commit 8277815349327b8e65226eb58ddb680f90c2c0c0 ]

The gop_length field is actually only u16 and there are two more u8
fields in the message:

- the number of consecutive b-frames
- frequency of golden frames

Fix the message and thus fix the configuration of the GOP length.

Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kelsey Skunberg <kelsey.skunberg@canonical.com>
drivers/staging/media/allegro-dvt/allegro-core.c

index 6f0cd07847863862e25abe822884373601cfaa90..c5a262a12e401da0b8d26138f669596b59f1dd84 100644 (file)
@@ -393,7 +393,10 @@ struct mcu_msg_create_channel {
        u32 freq_ird;
        u32 freq_lt;
        u32 gdr_mode;
-       u32 gop_length;
+       u16 gop_length;
+       u8 num_b;
+       u8 freq_golden_ref;
+
        u32 unknown39;
 
        u32 subframe_latency;