]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
scsi: hisi_sas: replace WARN_ON() with dev_warn() for internal abort
authorXiang Chen <chenxiang66@hisilicon.com>
Mon, 7 Nov 2016 12:48:34 +0000 (20:48 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 25 Nov 2016 14:54:39 +0000 (09:54 -0500)
Replace WARN_ON() with dev_warn() print when internal abort fails.

Signed-off-by: Xiang Chen <chenxiang66@hisilicon.com>
Signed-off-by: John Garry <john.garry@huawei.com>
Reviewed-by: Zhangfei Gao <zhangfei.gao@linaro.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/hisi_sas/hisi_sas_main.c

index 486aa927f92e78ccb0649873e9d3b5640d3f094d..9133238810eecc370c4294ec48e1b717f71fb182 100644 (file)
@@ -764,7 +764,8 @@ static int hisi_sas_exec_internal_tmf_task(struct domain_device *device,
                task = NULL;
        }
 ex_err:
-       WARN_ON(retry == TASK_RETRY);
+       if (retry == TASK_RETRY)
+               dev_warn(dev, "abort tmf: executing internal task failed!\n");
        sas_free_task(task);
        return res;
 }