]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
ipv4: ip_do_fragment: Preserve skb_iif during fragmentation
authorShmulik Ladkani <shmulik@metanetworks.com>
Mon, 29 Apr 2019 13:39:30 +0000 (16:39 +0300)
committerDavid S. Miller <davem@davemloft.net>
Wed, 1 May 2019 17:28:34 +0000 (13:28 -0400)
Previously, during fragmentation after forwarding, skb->skb_iif isn't
preserved, i.e. 'ip_copy_metadata' does not copy skb_iif from given
'from' skb.

As a result, ip_do_fragment's creates fragments with zero skb_iif,
leading to inconsistent behavior.

Assume for example an eBPF program attached at tc egress (post
forwarding) that examines __sk_buff->ingress_ifindex:
 - the correct iif is observed if forwarding path does not involve
   fragmentation/refragmentation
 - a bogus iif is observed if forwarding path involves
   fragmentation/refragmentatiom

Fix, by preserving skb_iif during 'ip_copy_metadata'.

Signed-off-by: Shmulik Ladkani <shmulik.ladkani@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/ip_output.c

index c80188875f39238f8d8ff33603cacf279d3f903a..e8bb2e85c5a471f018193b8a08735606ec7f0526 100644 (file)
@@ -519,6 +519,7 @@ static void ip_copy_metadata(struct sk_buff *to, struct sk_buff *from)
        to->pkt_type = from->pkt_type;
        to->priority = from->priority;
        to->protocol = from->protocol;
+       to->skb_iif = from->skb_iif;
        skb_dst_drop(to);
        skb_dst_copy(to, from);
        to->dev = from->dev;