]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
media: imx: imx7_mipi_csis: Fix logging of only error event counters
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Tue, 13 Apr 2021 02:29:52 +0000 (04:29 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Sun, 23 May 2021 17:21:31 +0000 (19:21 +0200)
The mipi_csis_events array ends with 6 non-error events, not 4. Update
mipi_csis_log_counters() accordingly. While at it, log event counters in
forward order, as there's no reason to log them backward.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Rui Miguel Silva <rmfrfs@gmail.com>
Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>
Tested-by: Frieder Schrempf <frieder.schrempf@kontron.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/imx/imx7-mipi-csis.c

index 1dc680d94a46ad7469ba95d4f5138e95900fb9b5..47e3175729c02511cd86590e53cf9971b10885a8 100644 (file)
@@ -666,13 +666,15 @@ static void mipi_csis_clear_counters(struct csi_state *state)
 
 static void mipi_csis_log_counters(struct csi_state *state, bool non_errors)
 {
-       int i = non_errors ? MIPI_CSIS_NUM_EVENTS : MIPI_CSIS_NUM_EVENTS - 4;
+       unsigned int num_events = non_errors ? MIPI_CSIS_NUM_EVENTS
+                               : MIPI_CSIS_NUM_EVENTS - 6;
        struct device *dev = &state->pdev->dev;
        unsigned long flags;
+       unsigned int i;
 
        spin_lock_irqsave(&state->slock, flags);
 
-       for (i--; i >= 0; i--) {
+       for (i = 0; i < num_events; ++i) {
                if (state->events[i].counter > 0 || state->debug)
                        dev_info(dev, "%s events: %d\n", state->events[i].name,
                                 state->events[i].counter);