]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
vme: tsi148: silence uninitialized variable warning
authorDmitry Kalinkin <dmitry.kalinkin@gmail.com>
Mon, 5 Oct 2015 03:59:17 +0000 (06:59 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 5 Oct 2015 09:59:34 +0000 (10:59 +0100)
The warning is a false positive.

drivers/vme/bridges/vme_tsi148.c: In function 'tsi148_master_write':
drivers/vme/bridges/vme_tsi148.c:1358:31: warning: 'handler' may be used uninitialized in this function [-Wmaybe-uninitialized]
   vme_unregister_error_handler(handler);
                               ^
drivers/vme/bridges/vme_tsi148.c: In function 'tsi148_master_read':
drivers/vme/bridges/vme_tsi148.c:1260:31: warning: 'handler' may be used uninitialized in this function [-Wmaybe-uninitialized]
   vme_unregister_error_handler(handler);
                               ^

Fixes: 0b0496625715 ("vme: change bus error handling scheme")
Signed-off-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/vme/bridges/vme_tsi148.c

index d1e383bc1f17e4322d7f45ca7fd4fedacc9683ae..60524834dba31b82237b92990f80c30868b33253 100644 (file)
@@ -1186,7 +1186,7 @@ static ssize_t tsi148_master_read(struct vme_master_resource *image, void *buf,
        int retval, enabled;
        unsigned long long vme_base, size;
        u32 aspace, cycle, dwidth;
-       struct vme_error_handler *handler;
+       struct vme_error_handler *handler = NULL;
        struct vme_bridge *tsi148_bridge;
        void __iomem *addr = image->kern_base + offset;
        unsigned int done = 0;
@@ -1276,7 +1276,7 @@ static ssize_t tsi148_master_write(struct vme_master_resource *image, void *buf,
        unsigned int done = 0;
        unsigned int count32;
 
-       struct vme_error_handler *handler;
+       struct vme_error_handler *handler = NULL;
        struct vme_bridge *tsi148_bridge;
        struct tsi148_driver *bridge;