]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
NFS: Don't interrupt file writeout due to fatal errors
authorTrond Myklebust <trondmy@gmail.com>
Sun, 7 Apr 2019 17:59:02 +0000 (13:59 -0400)
committerKhalid Elmously <khalid.elmously@canonical.com>
Fri, 14 Feb 2020 05:29:37 +0000 (00:29 -0500)
BugLink: https://bugs.launchpad.net/bugs/1863019
[ Upstream commit 14bebe3c90b326d2a0df78aed5e9de090c71d878 ]

When flushing out dirty pages, the fact that we may hit fatal errors
is not a reason to stop writeback. Those errors are reported through
fsync(), not through the flush mechanism.

Fixes: a6598813a4c5b ("NFS: Don't write back further requests if there...")
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
fs/nfs/write.c

index 0a0f99cad64c0b55bfa056acfb51b5f48a2c5984..df27794007b340df895bcd2f059be296ffa83ffc 100644 (file)
@@ -644,7 +644,7 @@ out:
        return ret;
 out_launder:
        nfs_write_error_remove_page(req);
-       return ret;
+       return 0;
 }
 
 static int nfs_do_writepage(struct page *page, struct writeback_control *wbc,