cifs: remove bogus debug code

The "end" pointer is either NULL or it points to the next byte to parse.
If there isn't a next byte then dereferencing "end" is an off-by-one out
of bounds error.  And, of course, if it's NULL that leads to an Oops.
Printing "*end" doesn't seem very useful so let's delete this code.

Also for the last debug statement, I noticed that it should be printing
"sequence_end" instead of "end" so fix that as well.

Reported-by: Dominik Maier <dmaier@sect.tu-berlin.de>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Steve French <stfrench@microsoft.com>

diff --git a/fs/cifs/asn1.c b/fs/cifs/asn1.c
index 689162e2e175511e7a1bcced02c5f8e8fc1e3149..3150c19cdc2fbed8537826b2d9f4537db4e9e5f3 100644 (file)
--- a/fs/cifs/asn1.c
+++ b/fs/cifs/asn1.c
@@ -530,8 +530,8 @@ decode_negTokenInit(unsigned char *security_blob, int length,
                return 0;
        } else if ((cls != ASN1_CTX) || (con != ASN1_CON)
                   || (tag != ASN1_EOC)) {
-               cifs_dbg(FYI, "cls = %d con = %d tag = %d end = %p (%d) exit 0\n",
-                        cls, con, tag, end, *end);
+               cifs_dbg(FYI, "cls = %d con = %d tag = %d end = %p exit 0\n",
+                        cls, con, tag, end);
                return 0;
        }
 
@@ -541,8 +541,8 @@ decode_negTokenInit(unsigned char *security_blob, int length,
                return 0;
        } else if ((cls != ASN1_UNI) || (con != ASN1_CON)
                   || (tag != ASN1_SEQ)) {
-               cifs_dbg(FYI, "cls = %d con = %d tag = %d end = %p (%d) exit 1\n",
-                        cls, con, tag, end, *end);
+               cifs_dbg(FYI, "cls = %d con = %d tag = %d end = %p exit 1\n",
+                        cls, con, tag, end);
                return 0;
        }
 
@@ -552,8 +552,8 @@ decode_negTokenInit(unsigned char *security_blob, int length,
                return 0;
        } else if ((cls != ASN1_CTX) || (con != ASN1_CON)
                   || (tag != ASN1_EOC)) {
-               cifs_dbg(FYI, "cls = %d con = %d tag = %d end = %p (%d) exit 0\n",
-                        cls, con, tag, end, *end);
+               cifs_dbg(FYI, "cls = %d con = %d tag = %d end = %p exit 0\n",
+                        cls, con, tag, end);
                return 0;
        }
 
@@ -564,8 +564,8 @@ decode_negTokenInit(unsigned char *security_blob, int length,
                return 0;
        } else if ((cls != ASN1_UNI) || (con != ASN1_CON)
                   || (tag != ASN1_SEQ)) {
-               cifs_dbg(FYI, "cls = %d con = %d tag = %d end = %p (%d) exit 1\n",
-                        cls, con, tag, end, *end);
+               cifs_dbg(FYI, "cls = %d con = %d tag = %d sequence_end = %p exit 1\n",
+                        cls, con, tag, sequence_end);
                return 0;
        }