]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
ARM: dts: s5pv210: move fixed clocks under root node
authorKrzysztof Kozlowski <krzk@kernel.org>
Mon, 7 Sep 2020 16:11:22 +0000 (18:11 +0200)
committerKrzysztof Kozlowski <krzk@kernel.org>
Wed, 9 Sep 2020 19:38:07 +0000 (21:38 +0200)
The fixed clocks are kept under dedicated 'external-clocks' node, thus a
fake 'reg' was added.  This is not correct with dtschema as fixed-clock
binding does not have a 'reg' property.  Moving fixed clocks out of
'soc' to root node fixes multiple dtbs_check warnings:

  external-clocks: $nodename:0: 'external-clocks' does not match '^([a-z][a-z0-9\\-]+-bus|bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$'
  external-clocks: #size-cells:0:0: 0 is not one of [1, 2]
  external-clocks: oscillator@0:reg:0: [0] is too short
  external-clocks: oscillator@1:reg:0: [1] is too short
  external-clocks: 'ranges' is a required property
  oscillator@0: 'reg' does not match any of the regexes: 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Tested-by: Jonathan Bakker <xc-racer2@live.ca>
Link: https://lore.kernel.org/r/20200907161141.31034-7-krzk@kernel.org
arch/arm/boot/dts/s5pv210.dtsi

index 84e4447931de5913ecc8c3694f98449ae4a5affa..5c760a6d79557ee9d55e573adee675d54f74dde7 100644 (file)
                };
        };
 
+       xxti: oscillator-0 {
+               compatible = "fixed-clock";
+               clock-frequency = <0>;
+               clock-output-names = "xxti";
+               #clock-cells = <0>;
+       };
+
+       xusbxti: oscillator-1 {
+               compatible = "fixed-clock";
+               clock-frequency = <0>;
+               clock-output-names = "xusbxti";
+               #clock-cells = <0>;
+       };
+
        soc {
                compatible = "simple-bus";
                #address-cells = <1>;
                #size-cells = <1>;
                ranges;
 
-               external-clocks {
-                       compatible = "simple-bus";
-                       #address-cells = <1>;
-                       #size-cells = <0>;
-
-                       xxti: oscillator@0 {
-                               compatible = "fixed-clock";
-                               reg = <0>;
-                               clock-frequency = <0>;
-                               clock-output-names = "xxti";
-                               #clock-cells = <0>;
-                       };
-
-                       xusbxti: oscillator@1 {
-                               compatible = "fixed-clock";
-                               reg = <1>;
-                               clock-frequency = <0>;
-                               clock-output-names = "xusbxti";
-                               #clock-cells = <0>;
-                       };
-               };
-
                onenand: onenand@b0600000 {
                        compatible = "samsung,s5pv210-onenand";
                        reg = <0xb0600000 0x2000>,