]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commitdiff
iio: sca3000: Remove an erroneous 'get_device()'
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Wed, 6 May 2020 03:52:06 +0000 (05:52 +0200)
committerMarcelo Henrique Cerri <marcelo.cerri@canonical.com>
Mon, 22 Jun 2020 20:22:46 +0000 (17:22 -0300)
BugLink: https://bugs.launchpad.net/bugs/1881178
commit 928edefbc18cd8433f7df235c6e09a9306e7d580 upstream.

This looks really unusual to have a 'get_device()' hidden in a 'dev_err()'
call.
Remove it.

While at it add a missing \n at the end of the message.

Fixes: 574fb258d636 ("Staging: IIO: VTI sca3000 series accelerometer driver (spi)")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/iio/accel/sca3000.c

index 66d768d971e1e6212219b219673399f9fe4eded0..6e429072e44a489b6ccd11a2085580d80449c533 100644 (file)
@@ -980,7 +980,7 @@ static int sca3000_read_data(struct sca3000_state *st,
        st->tx[0] = SCA3000_READ_REG(reg_address_high);
        ret = spi_sync_transfer(st->us, xfer, ARRAY_SIZE(xfer));
        if (ret) {
-               dev_err(get_device(&st->us->dev), "problem reading register");
+               dev_err(&st->us->dev, "problem reading register\n");
                return ret;
        }