]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
powerpc/pseries/vas: Ignore VAS update for DLPAR if copy/paste is not enabled
authorHaren Myneni <haren@linux.ibm.com>
Tue, 21 Mar 2023 02:50:08 +0000 (19:50 -0700)
committerRoxana Nicolescu <roxana.nicolescu@canonical.com>
Wed, 17 May 2023 11:33:51 +0000 (13:33 +0200)
BugLink: https://bugs.launchpad.net/bugs/2016878
commit eca9f6e6f83b6725b84e1c76fdde19b003cff0eb upstream.

The hypervisor supports user-mode NX from Power10.

pseries_vas_dlpar_cpu() is called from lparcfg_write() to update VAS
windows for DLPAR event in shared processor mode and the kernel gets
-ENOTSUPP for HCALLs if the user-mode NX is not supported. The current
VAS implementation also supports only with Radix page tables. Whereas in
dedicated processor mode, pseries_vas_notifier() is registered only if
the copy/paste feature is enabled. So instead of displaying HCALL error
messages, update VAS capabilities if the copy/paste feature is
available.

This patch ignores updating VAS capabilities in pseries_vas_dlpar_cpu()
and returns success if the copy/paste feature is not enabled. Then
lparcfg_write() completes the processor DLPAR operations without any
failures.

Fixes: 2147783d6bf0 ("powerpc/pseries: Use lparcfg to reconfig VAS windows for DLPAR CPU")
Cc: stable@vger.kernel.org # v6.1+
Signed-off-by: Haren Myneni <haren@linux.ibm.com>
Reviewed-by: Nathan Lynch <nathanl@linux.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://msgid.link/1d0e727e7dbd9a28627ef08ca9df9c86a50175e2.camel@linux.ibm.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
arch/powerpc/platforms/pseries/vas.c

index 4ad6e510d405fdc1c10345b85e59b94fa54537df..94c023bb13e0511b616240ab44aa80fe53ba4135 100644 (file)
@@ -857,6 +857,13 @@ int pseries_vas_dlpar_cpu(void)
 {
        int new_nr_creds, rc;
 
+       /*
+        * NX-GZIP is not enabled. Nothing to do for DLPAR event
+        */
+       if (!copypaste_feat)
+               return 0;
+
+
        rc = h_query_vas_capabilities(H_QUERY_VAS_CAPABILITIES,
                                      vascaps[VAS_GZIP_DEF_FEAT_TYPE].feat,
                                      (u64)virt_to_phys(&hv_cop_caps));
@@ -1013,6 +1020,7 @@ static int __init pseries_vas_init(void)
         * Linux supports user space COPY/PASTE only with Radix
         */
        if (!radix_enabled()) {
+               copypaste_feat = false;
                pr_err("API is supported only with radix page tables\n");
                return -ENOTSUPP;
        }