]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
ASoC: tas2770: Fix unbalanced calls to pm_runtime
authorDan Murphy <dmurphy@ti.com>
Fri, 18 Sep 2020 19:05:44 +0000 (14:05 -0500)
committerMark Brown <broonie@kernel.org>
Mon, 21 Sep 2020 22:57:20 +0000 (23:57 +0100)
Fix the unbalanced call to the pm_runtime_disable when removing the
module.  pm_runtime_enable is not called nor is the pm_runtime setup in
the code.  Remove the i2c_remove function and the pm_runtime_disable.

Fixes: 1a476abc723e6 ("tas2770: add tas2770 smart PA kernel driver")
Signed-off-by: Dan Murphy <dmurphy@ti.com>
Link: https://lore.kernel.org/r/20200918190548.12598-5-dmurphy@ti.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/tas2770.c

index 15cdd8b11a67a79612e6a99cc63d1551546e2012..3226c6d4493eb28f8f1b979334556bf3691d7a0a 100644 (file)
@@ -16,7 +16,6 @@
 #include <linux/i2c.h>
 #include <linux/gpio.h>
 #include <linux/gpio/consumer.h>
-#include <linux/pm_runtime.h>
 #include <linux/regulator/consumer.h>
 #include <linux/firmware.h>
 #include <linux/regmap.h>
@@ -781,13 +780,6 @@ end:
        return result;
 }
 
-static int tas2770_i2c_remove(struct i2c_client *client)
-{
-       pm_runtime_disable(&client->dev);
-       return 0;
-}
-
-
 static const struct i2c_device_id tas2770_i2c_id[] = {
        { "tas2770", 0},
        { }
@@ -808,7 +800,6 @@ static struct i2c_driver tas2770_i2c_driver = {
                .of_match_table = of_match_ptr(tas2770_of_match),
        },
        .probe      = tas2770_i2c_probe,
-       .remove     = tas2770_i2c_remove,
        .id_table   = tas2770_i2c_id,
 };