]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
sunvnet: remove unused variable in maybe_tx_wakeup
authorSowmini Varadhan <sowmini.varadhan@oracle.com>
Mon, 13 Feb 2017 18:56:58 +0000 (10:56 -0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 14 Feb 2017 18:04:09 +0000 (13:04 -0500)
The vio_dring_state *dr variable is unused in maybe_tx_wakeup().
As the comments indicate, we call maybe_tx_wakeup() whenever we
get a STOPPED LDC message on the port. If the queue is stopped,
we want to wake it up so that we will send another START message
at the next TX and trigger the consumer to drain the dring.

Signed-off-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>
Signed-off-by: Shannon Nelson <shannon.nelson@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/sun/sunvnet_common.c

index c71f0007ad5b6d52272fc495afdf268fa689c8bf..0f940f0e488db81618262a8c25bff3bfb56b5805 100644 (file)
@@ -719,12 +719,8 @@ static void maybe_tx_wakeup(struct vnet_port *port)
        txq = netdev_get_tx_queue(VNET_PORT_TO_NET_DEVICE(port),
                                  port->q_index);
        __netif_tx_lock(txq, smp_processor_id());
-       if (likely(netif_tx_queue_stopped(txq))) {
-               struct vio_dring_state *dr;
-
-               dr = &port->vio.drings[VIO_DRIVER_TX_RING];
+       if (likely(netif_tx_queue_stopped(txq)))
                netif_tx_wake_queue(txq);
-       }
        __netif_tx_unlock(txq);
 }