]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
drm/amdgpu: remove unnecessary tOS version check
authorHawking Zhang <Hawking.Zhang@amd.com>
Mon, 20 Apr 2020 07:57:26 +0000 (15:57 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 23 Apr 2020 19:40:22 +0000 (15:40 -0400)
tOS version is available through debugfs interface

Signed-off-by: Hawking Zhang <Hawking.Zhang@amd.com>
Reviewed-by: Guchun Chen <guchun.chen@amd.com>
Reviewed-by: John Clements <john.clements@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
drivers/gpu/drm/amd/amdgpu/psp_v12_0.c
drivers/gpu/drm/amd/amdgpu/psp_v3_1.c

index 46ef0082ca8ea908e73294262d45e97f80d98e50..20fbd43f2ffaed33c714cc7d16fe28df12a21aaf 100644 (file)
@@ -283,11 +283,8 @@ static int psp_v11_0_bootloader_load_kdb(struct psp_context *psp)
        /* Check tOS sign of life register to confirm sys driver and sOS
         * are already been loaded.
         */
-       if (psp_v11_0_is_sos_alive(psp)) {
-               psp->sos_fw_version = RREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_58);
-               dev_info(adev->dev, "sos fw version = 0x%x.\n", psp->sos_fw_version);
+       if (psp_v11_0_is_sos_alive(psp))
                return 0;
-       }
 
        ret = psp_v11_0_wait_for_bootloader(psp);
        if (ret)
@@ -319,11 +316,8 @@ static int psp_v11_0_bootloader_load_sysdrv(struct psp_context *psp)
        /* Check sOS sign of life register to confirm sys driver and sOS
         * are already been loaded.
         */
-       if (psp_v11_0_is_sos_alive(psp)) {
-               psp->sos_fw_version = RREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_58);
-               dev_info(adev->dev, "sos fw version = 0x%x.\n", psp->sos_fw_version);
+       if (psp_v11_0_is_sos_alive(psp))
                return 0;
-       }
 
        ret = psp_v11_0_wait_for_bootloader(psp);
        if (ret)
index 17e4475dadd65f1d1ba5c62088ecaec038f33afd..d3c86a0f1bd48e59ae36cc121888a7d32393854b 100644 (file)
@@ -95,11 +95,8 @@ static int psp_v12_0_bootloader_load_sysdrv(struct psp_context *psp)
         * are already been loaded.
         */
        sol_reg = RREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_81);
-       if (sol_reg) {
-               psp->sos_fw_version = RREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_58);
-               printk("sos fw version = 0x%x.\n", psp->sos_fw_version);
+       if (sol_reg)
                return 0;
-       }
 
        /* Wait for bootloader to signify that is ready having bit 31 of C2PMSG_35 set to 1 */
        ret = psp_wait_for(psp, SOC15_REG_OFFSET(MP0, 0, mmMP0_SMN_C2PMSG_35),
index bd13625238e1d3f11310f09b811ae44cc635520e..ab03190cf100c53dff1e73cf42d1bb005b5d691f 100644 (file)
@@ -197,11 +197,8 @@ static int psp_v3_1_bootloader_load_sos(struct psp_context *psp)
         * are already been loaded.
         */
        sol_reg = RREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_81);
-       if (sol_reg) {
-               psp->sos_fw_version = RREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_58);
-               printk("sos fw version = 0x%x.\n", psp->sos_fw_version);
+       if (sol_reg)
                return 0;
-       }
 
        /* Wait for bootloader to signify that is ready having bit 31 of C2PMSG_35 set to 1 */
        ret = psp_wait_for(psp, SOC15_REG_OFFSET(MP0, 0, mmMP0_SMN_C2PMSG_35),