]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
clk: meson: meson8b: Drop CLK_IS_CRITICAL from fclk_div2
authorMartin Blumenstingl <martin.blumenstingl@googlemail.com>
Sat, 20 Jun 2020 16:14:22 +0000 (18:14 +0200)
committerJerome Brunet <jbrunet@baylibre.com>
Wed, 24 Jun 2020 10:14:30 +0000 (12:14 +0200)
Drop CLK_IS_CRITICAL from fclk_div2. This was added because we didn't
know the relation between this clock and RGMII Ethernet. It turns out
that fclk_div2 is used as "timing adjustment clock" to generate the RX
delay on the MAC side - which was enabled by u-boot on Odriod-C1. When
using the RX delay on the PHY side or not using a RX delay at all then
this clock can be disabled.

Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
Link: https://lore.kernel.org/r/20200620161422.24114-1-martin.blumenstingl@googlemail.com
drivers/clk/meson/meson8b.c

index edc09d050ecf42d84cdb3a2a0c60903de46b24e2..3d826711c820b3f01fd358dbdbcf38a1d6ab3100 100644 (file)
@@ -293,13 +293,6 @@ static struct clk_regmap meson8b_fclk_div2 = {
                        &meson8b_fclk_div2_div.hw
                },
                .num_parents = 1,
-               /*
-                * FIXME: Ethernet with a RGMII PHYs is not working if
-                * fclk_div2 is disabled. it is currently unclear why this
-                * is. keep it enabled until the Ethernet driver knows how
-                * to manage this clock.
-                */
-               .flags = CLK_IS_CRITICAL,
        },
 };