]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
amd-xgbe: Use __napi_schedule() in BH context
authorSebastian Andrzej Siewior <bigeasy@linutronix.de>
Thu, 16 Apr 2020 15:57:40 +0000 (17:57 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 16 Apr 2020 20:59:53 +0000 (13:59 -0700)
The driver uses __napi_schedule_irqoff() which is fine as long as it is
invoked with disabled interrupts by everybody. Since the commit
mentioned below the driver may invoke xgbe_isr_task() in tasklet/softirq
context. This may lead to list corruption if another driver uses
__napi_schedule_irqoff() in IRQ context.

Use __napi_schedule() which safe to use from IRQ and softirq context.

Fixes: 85b85c853401d ("amd-xgbe: Re-issue interrupt if interrupt status not cleared")
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Acked-by: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/amd/xgbe/xgbe-drv.c

index b71f9b04a51e187ce96fb4073287bc4393901cd9..a87264f95f1a49b39211690da0db147d571d2bcb 100644 (file)
@@ -514,7 +514,7 @@ static void xgbe_isr_task(unsigned long data)
                                xgbe_disable_rx_tx_ints(pdata);
 
                                /* Turn on polling */
-                               __napi_schedule_irqoff(&pdata->napi);
+                               __napi_schedule(&pdata->napi);
                        }
                } else {
                        /* Don't clear Rx/Tx status if doing per channel DMA