]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commitdiff
USB: ehci: Fix isoc scheduling boundary checking.
authorSarah Sharp <sarah.a.sharp@linux.intel.com>
Tue, 6 Oct 2009 20:45:59 +0000 (13:45 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 9 Oct 2009 20:52:08 +0000 (13:52 -0700)
The EHCI driver does some bounds checking when it's scheduling an iTD for
an active endpoint.  It sets the local variable start to
stream->next_uframe and moves that variable further in the schedule if
necessary.  However, the driver fails to do anything with start before
jumping to the ready label and setting the URB's starting frame to
stream->next_uframe.  Alan Stern confirms the EHCI driver should set
stream->next_uframe to start before jumping.

Signed-off-by: Sarah Sharp <sarah.a.sharp@linux.intel.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/host/ehci-sched.c

index 3ea05936851ff72568ff1e655300eee6bd013df9..3efa59b1804406f184c00999595cd09ae4e6f411 100644 (file)
@@ -1425,6 +1425,7 @@ iso_stream_schedule (
                        status = -EFBIG;
                        goto fail;
                }
+               stream->next_uframe = start;
                goto ready;
        }