pwm: lpss: Log error from pwm_lpss_is_updating() if the update bit is still set

pwm_lpss_is_updating() does a sanity check which should never fail.
If the check does actually fail that is worth logging an error,
especially since this means that we will skip making the requested
changes to the PWM settings.

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>

diff --git a/drivers/pwm/pwm-lpss.c b/drivers/pwm/pwm-lpss.c
index 3444c56b4bede25b09f9f9314f657b6cf14104c0..939de93c157b2fe69eda42e4698a1023ae700648 100644 (file)
--- a/drivers/pwm/pwm-lpss.c
+++ b/drivers/pwm/pwm-lpss.c
@@ -76,7 +76,12 @@ static int pwm_lpss_wait_for_update(struct pwm_device *pwm)
 
 static inline int pwm_lpss_is_updating(struct pwm_device *pwm)
 {
-       return (pwm_lpss_read(pwm) & PWM_SW_UPDATE) ? -EBUSY : 0;
+       if (pwm_lpss_read(pwm) & PWM_SW_UPDATE) {
+               dev_err(pwm->chip->dev, "PWM_SW_UPDATE is still set, skipping update\n");
+               return -EBUSY;
+       }
+
+       return 0;
 }
 
 static void pwm_lpss_prepare(struct pwm_lpss_chip *lpwm, struct pwm_device *pwm,