]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
drm/amdgpu: fix pm sysfs node handling (v2)
authorAlex Deucher <alexander.deucher@amd.com>
Thu, 21 May 2020 14:08:11 +0000 (10:08 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 22 May 2020 17:41:37 +0000 (13:41 -0400)
Fix typos that prevented them from showing up.

v2: switch other files in addition to pp_clk_voltage

Fixes: 4e01847c38f7a5 ("drm/amdgpu: optimize amdgpu device attribute code")
Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1150
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Acked-by: Evan Quan <evan.quan@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c

index 2fc51f815eaa569ab9f005c2fa5dc7c2e9ddf4a8..e06fef6174e5ab874bcb642992ae7926c3c3efc8 100644 (file)
@@ -1731,10 +1731,10 @@ static int default_attr_update(struct amdgpu_device *adev, struct amdgpu_device_
 #define DEVICE_ATTR_IS(_name)  (!strcmp(attr_name, #_name))
 
        if (DEVICE_ATTR_IS(pp_dpm_socclk)) {
-               if (asic_type <= CHIP_VEGA10)
+               if (asic_type < CHIP_VEGA10)
                        attr->states = ATTR_STATE_UNSUPPORTED;
        } else if (DEVICE_ATTR_IS(pp_dpm_dcefclk)) {
-               if (asic_type <= CHIP_VEGA10 || asic_type == CHIP_ARCTURUS)
+               if (asic_type < CHIP_VEGA10 || asic_type == CHIP_ARCTURUS)
                        attr->states = ATTR_STATE_UNSUPPORTED;
        } else if (DEVICE_ATTR_IS(pp_dpm_fclk)) {
                if (asic_type < CHIP_VEGA20)
@@ -1746,7 +1746,7 @@ static int default_attr_update(struct amdgpu_device *adev, struct amdgpu_device_
                attr->states = ATTR_STATE_UNSUPPORTED;
                if ((is_support_sw_smu(adev) && adev->smu.od_enabled) ||
                    (!is_support_sw_smu(adev) && hwmgr->od_enabled))
-                       attr->states = ATTR_STATE_UNSUPPORTED;
+                       attr->states = ATTR_STATE_SUPPORTED;
        } else if (DEVICE_ATTR_IS(mem_busy_percent)) {
                if (adev->flags & AMD_IS_APU || asic_type == CHIP_VEGA10)
                        attr->states = ATTR_STATE_UNSUPPORTED;
@@ -1758,7 +1758,7 @@ static int default_attr_update(struct amdgpu_device *adev, struct amdgpu_device_
                if (!adev->unique_id)
                        attr->states = ATTR_STATE_UNSUPPORTED;
        } else if (DEVICE_ATTR_IS(pp_features)) {
-               if (adev->flags & AMD_IS_APU || asic_type <= CHIP_VEGA10)
+               if (adev->flags & AMD_IS_APU || asic_type < CHIP_VEGA10)
                        attr->states = ATTR_STATE_UNSUPPORTED;
        }