]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
net/ixgbevf: fix a compilation error of skb_frag_t
authorQian Cai <cai@lca.pw>
Wed, 24 Jul 2019 16:17:59 +0000 (12:17 -0400)
committerDavid S. Miller <davem@davemloft.net>
Wed, 24 Jul 2019 22:28:43 +0000 (15:28 -0700)
The linux-next commit "net: Rename skb_frag_t size to bv_len" [1]
introduced a compilation error on powerpc as it forgot to deal with the
renaming from "size" to "bv_len" for ixgbevf.

[1] https://lore.kernel.org/netdev/20190723030831.11879-1-willy@infradead.org/T/#md052f1c7de965ccd1bdcb6f92e1990a52298eac5

In file included from ./include/linux/cache.h:5,
                 from ./include/linux/printk.h:9,
                 from ./include/linux/kernel.h:15,
                 from ./include/linux/list.h:9,
                 from ./include/linux/module.h:9,
                 from
drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c:12:
drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c: In function
'ixgbevf_xmit_frame_ring':
drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c:4138:51: error:
'skb_frag_t' {aka 'struct bio_vec'} has no member named 'size'
   count += TXD_USE_COUNT(skb_shinfo(skb)->frags[f].size);
                                                   ^
./include/uapi/linux/kernel.h:13:40: note: in definition of macro
'__KERNEL_DIV_ROUND_UP'
 #define __KERNEL_DIV_ROUND_UP(n, d) (((n) + (d) - 1) / (d))
                                        ^
drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c:4138:12: note: in
expansion of macro 'TXD_USE_COUNT'
   count += TXD_USE_COUNT(skb_shinfo(skb)->frags[f].size);

Signed-off-by: Qian Cai <cai@lca.pw>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c

index bdfccaf38edddd7d4428329a6cb29c9f13d960f3..8c011d4ce7a98c1fc34dc09b126fa20c5ad5a550 100644 (file)
@@ -4134,8 +4134,11 @@ static int ixgbevf_xmit_frame_ring(struct sk_buff *skb,
         * otherwise try next time
         */
 #if PAGE_SIZE > IXGBE_MAX_DATA_PER_TXD
-       for (f = 0; f < skb_shinfo(skb)->nr_frags; f++)
-               count += TXD_USE_COUNT(skb_shinfo(skb)->frags[f].size);
+       for (f = 0; f < skb_shinfo(skb)->nr_frags; f++) {
+               skb_frag_t *frag = &skb_shinfo(skb)->frags[f];
+
+               count += TXD_USE_COUNT(skb_frag_size(frag));
+       }
 #else
        count += skb_shinfo(skb)->nr_frags;
 #endif