virtio: pci: Fix an error handling path in vp_modern_probe()

BugLink: https://bugs.launchpad.net/bugs/1982968
[ Upstream commit 7a836a2aba09479c8e71fa43249eecc4af945f61 ]

If an error occurs after a successful pci_request_selected_regions() call,
it should be undone by a corresponding pci_release_selected_regions() call,
as already done in vp_modern_remove().

Fixes: fd502729fbbf ("virtio-pci: introduce modern device module")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Message-Id: <237109725aad2c3c03d14549f777b1927c84b045.1648977064.git.christophe.jaillet@wanadoo.fr>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>

diff --git a/drivers/virtio/virtio_pci_modern_dev.c b/drivers/virtio/virtio_pci_modern_dev.c
index e11ed748e66131d2a51afcc4423efa7ae640b1ce..9ab66e44738eebcc2d2235db03df69347d2ac003 100644 (file)
--- a/drivers/virtio/virtio_pci_modern_dev.c
+++ b/drivers/virtio/virtio_pci_modern_dev.c
@@ -340,6 +340,7 @@ err_map_notify:
 err_map_isr:
        pci_iounmap(pci_dev, mdev->common);
 err_map_common:
+       pci_release_selected_regions(pci_dev, mdev->modern_bars);
        return err;
 }
 EXPORT_SYMBOL_GPL(vp_modern_probe);