]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
can: mcp251x: avoid write to error flag register if it's unnecessary
authorEd Spiridonov <edo.rus@gmail.com>
Fri, 4 Mar 2016 06:07:27 +0000 (09:07 +0300)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Fri, 4 Mar 2016 07:45:17 +0000 (08:45 +0100)
Only two bits (RX0OVR and RX1OVR) are writable in EFLG, write is useless
if these bits aren't set.

Signed-off-by: Ed Spiridonov <edo.rus@gmail.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/spi/mcp251x.c

index 575790e8a75af8e6184f5611fe133b1d73825679..74a7dfecee2783ac609b9fefbd32f7817b48c43c 100644 (file)
@@ -843,7 +843,7 @@ static irqreturn_t mcp251x_can_ist(int irq, void *dev_id)
                if (clear_intf)
                        mcp251x_write_bits(spi, CANINTF, clear_intf, 0x00);
 
-               if (eflag)
+               if (eflag & (EFLG_RX0OVR | EFLG_RX1OVR))
                        mcp251x_write_bits(spi, EFLG, eflag, 0x00);
 
                /* Update can state */