]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
drm/radeon: Fix fall-through warnings for Clang
authorGustavo A. R. Silva <gustavoars@kernel.org>
Fri, 20 Nov 2020 18:24:49 +0000 (12:24 -0600)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 24 Nov 2020 17:05:42 +0000 (12:05 -0500)
In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
warnings by explicitly adding multiple fallthrough pseudo-keyword macros,
as replacement for /* fall through */ comments.

Notice that Clang doesn't recognize /* fall through */ comments as
implicit fall-through markings.

Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/radeon/ci_dpm.c
drivers/gpu/drm/radeon/r300.c
drivers/gpu/drm/radeon/si_dpm.c

index 0dfb0ed9af89d7a0efdd8e9c610cda0694b797be..f0cfb58da467246c77569baf863209d788c64ed1 100644 (file)
@@ -4839,8 +4839,8 @@ static void ci_request_link_speed_change_before_state_change(struct radeon_devic
                case RADEON_PCIE_GEN2:
                        if (radeon_acpi_pcie_performance_request(rdev, PCIE_PERF_REQ_PECI_GEN2, false) == 0)
                                break;
+                       fallthrough;
 #endif
-                       /* fall through */
                default:
                        pi->force_pcie_gen = ci_get_current_pcie_speed(rdev);
                        break;
index 73f67bf222e1648894f58224f1f72b6a2dc4016c..213dc49b632233e2dcaa1141ae2115c6450f303a 100644 (file)
@@ -1162,6 +1162,7 @@ static int r300_packet0_check(struct radeon_cs_parser *p,
                /* valid register only on RV530 */
                if (p->rdev->family == CHIP_RV530)
                        break;
+               fallthrough;
                /* fallthrough do not move */
        default:
                goto fail;
index cd07b06301b447ba3917befc3d10998a115b040d..91bfc4762767b67c6828f751858514e35f116bf0 100644 (file)
@@ -5745,8 +5745,8 @@ static void si_request_link_speed_change_before_state_change(struct radeon_devic
                case RADEON_PCIE_GEN2:
                        if (radeon_acpi_pcie_performance_request(rdev, PCIE_PERF_REQ_PECI_GEN2, false) == 0)
                                break;
+                       fallthrough;
 #endif
-                       /* fall through */
                default:
                        si_pi->force_pcie_gen = si_get_current_pcie_speed(rdev);
                        break;