]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
cxgb4/l2t: Simplify 't4_l2e_free()' and '_t4_l2e_free()'
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Thu, 31 Oct 2019 05:53:45 +0000 (06:53 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 31 Oct 2019 17:37:59 +0000 (10:37 -0700)
Use '__skb_queue_purge()' instead of re-implementing it.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/chelsio/cxgb4/l2t.c

index 1a407d3c1d67c2ef9c117c2eee9fcfa05e76fa17..e9e45006632da66dcb0bc49ba783343f8ad166b4 100644 (file)
@@ -351,15 +351,13 @@ exists:
 static void _t4_l2e_free(struct l2t_entry *e)
 {
        struct l2t_data *d;
-       struct sk_buff *skb;
 
        if (atomic_read(&e->refcnt) == 0) {  /* hasn't been recycled */
                if (e->neigh) {
                        neigh_release(e->neigh);
                        e->neigh = NULL;
                }
-               while ((skb = __skb_dequeue(&e->arpq)) != NULL)
-                       kfree_skb(skb);
+               __skb_queue_purge(&e->arpq);
        }
 
        d = container_of(e, struct l2t_data, l2tab[e->idx]);
@@ -370,7 +368,6 @@ static void _t4_l2e_free(struct l2t_entry *e)
 static void t4_l2e_free(struct l2t_entry *e)
 {
        struct l2t_data *d;
-       struct sk_buff *skb;
 
        spin_lock_bh(&e->lock);
        if (atomic_read(&e->refcnt) == 0) {  /* hasn't been recycled */
@@ -378,8 +375,7 @@ static void t4_l2e_free(struct l2t_entry *e)
                        neigh_release(e->neigh);
                        e->neigh = NULL;
                }
-               while ((skb = __skb_dequeue(&e->arpq)) != NULL)
-                       kfree_skb(skb);
+               __skb_queue_purge(&e->arpq);
        }
        spin_unlock_bh(&e->lock);