]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
media: solo6x10: make const array saa7128_regs_ntsc static
authorColin Ian King <colin.king@canonical.com>
Mon, 10 Jul 2017 18:51:03 +0000 (14:51 -0400)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Wed, 19 Jul 2017 19:12:15 +0000 (15:12 -0400)
Don't populate const array saa7128_regs_ntsc on the stack but insteaed make
it static.  Makes the object code smaller and saves nearly 840 bytes

Before:
   text    data     bss     dec     hex filename
   9218     360       0    9578    256a solo6x10-tw28.o

After:
   text    data     bss     dec     hex filename
   8237     504       0    8741    2225 solo6x10-tw28.o

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Ismael Luceno <ismael@iodev.co.uk>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/pci/solo6x10/solo6x10-tw28.c

index 0632d3f7c73c420de029fae76c75c2945853e58a..1c013a03d85124aaba26cea510e81fcc0ee2799d 100644 (file)
@@ -532,7 +532,7 @@ static void saa712x_write_regs(struct solo_dev *dev, const u8 *vals,
 static void saa712x_setup(struct solo_dev *dev)
 {
        const int reg_start = 0x26;
-       const u8 saa7128_regs_ntsc[] = {
+       static const u8 saa7128_regs_ntsc[] = {
        /* :0x26 */
                0x0d, 0x00,
        /* :0x28 */