]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
clk: kirkwood: fix refcount leak in kirkwood_clk_init()
authorYangtao Li <tiny.windzz@gmail.com>
Wed, 26 Dec 2018 13:40:19 +0000 (08:40 -0500)
committerKhalid Elmously <khalid.elmously@canonical.com>
Fri, 14 Feb 2020 05:29:37 +0000 (00:29 -0500)
BugLink: https://bugs.launchpad.net/bugs/1863019
[ Upstream commit e7beeab9c61591cd0e690d8733d534c3f4278ff8 ]

The of_find_compatible_node() returns a node pointer with refcount
incremented, but there is the lack of use of the of_node_put() when
done. Add the missing of_node_put() to release the refcount.

Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
Reviewed-by: Gregory CLEMENT <gregory.clement@bootlin.com>
Fixes: 58d516ae95cb ("clk: mvebu: kirkwood: maintain clock init order")
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/clk/mvebu/kirkwood.c

index a2a8d614039da91a1b3f99272aa98e5952b79037..890ebf623261b78d237881eb39a51c51e9074a73 100644 (file)
@@ -333,6 +333,8 @@ static void __init kirkwood_clk_init(struct device_node *np)
        if (cgnp) {
                mvebu_clk_gating_setup(cgnp, kirkwood_gating_desc);
                kirkwood_clk_muxing_setup(cgnp, kirkwood_mux_desc);
+
+               of_node_put(cgnp);
        }
 }
 CLK_OF_DECLARE(kirkwood_clk, "marvell,kirkwood-core-clock",