mips: kernel: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: Paul Burton <paul.burton@mips.com>
Cc: James Hogan <jhogan@kernel.org>
Cc: Yangtao Li <tiny.windzz@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Mike Rapoport <rppt@linux.vnet.ibm.com>
Cc: Mathieu Malaterre <malat@debian.org>
Cc: Huacai Chen <chenhc@lemote.com>
Cc: Marcin Nowakowski <marcin.nowakowski@mips.com>
Cc: Yasha Cherikovsky <yasha.che3@gmail.com>
Cc: linux-mips@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Paul Burton <paul.burton@mips.com>

diff --git a/arch/mips/kernel/mips-r2-to-r6-emul.c b/arch/mips/kernel/mips-r2-to-r6-emul.c
index c50c89a978f12761b7ed688517343e4ba37ed7bb..b4d210bfcdae0f0deb4e4e61ff2f628c25cf51f0 100644 (file)
--- a/arch/mips/kernel/mips-r2-to-r6-emul.c
+++ b/arch/mips/kernel/mips-r2-to-r6-emul.c
@@ -2351,23 +2351,10 @@ DEFINE_SHOW_ATTRIBUTE(mipsr2_clear);
 
 static int __init mipsr2_init_debugfs(void)
 {
-       struct dentry           *mipsr2_emul;
-
-       if (!mips_debugfs_dir)
-               return -ENODEV;
-
-       mipsr2_emul = debugfs_create_file("r2_emul_stats", S_IRUGO,
-                                         mips_debugfs_dir, NULL,
-                                         &mipsr2_emul_fops);
-       if (!mipsr2_emul)
-               return -ENOMEM;
-
-       mipsr2_emul = debugfs_create_file("r2_emul_stats_clear", S_IRUGO,
-                                         mips_debugfs_dir, NULL,
-                                         &mipsr2_clear_fops);
-       if (!mipsr2_emul)
-               return -ENOMEM;
-
+       debugfs_create_file("r2_emul_stats", S_IRUGO, mips_debugfs_dir, NULL,
+                           &mipsr2_emul_fops);
+       debugfs_create_file("r2_emul_stats_clear", S_IRUGO, mips_debugfs_dir,
+                           NULL, &mipsr2_clear_fops);
        return 0;
 }
 

diff --git a/arch/mips/kernel/segment.c b/arch/mips/kernel/segment.c
index 2703f218202e167ffda5b1ff0ac7f2a41ca8df7c..0a9bd7b0983b93333d7fcfadc1cece892cc0aa55 100644 (file)
--- a/arch/mips/kernel/segment.c
+++ b/arch/mips/kernel/segment.c
@@ -95,18 +95,9 @@ static const struct file_operations segments_fops = {
 
 static int __init segments_info(void)
 {
-       struct dentry *segments;
-
-       if (cpu_has_segments) {
-               if (!mips_debugfs_dir)
-                       return -ENODEV;
-
-               segments = debugfs_create_file("segments", S_IRUGO,
-                                              mips_debugfs_dir, NULL,
-                                              &segments_fops);
-               if (!segments)
-                       return -ENOMEM;
-       }
+       if (cpu_has_segments)
+               debugfs_create_file("segments", S_IRUGO, mips_debugfs_dir, NULL,
+                                   &segments_fops);
        return 0;
 }
 

diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c
index 8c6c48ed786a1527c22ba5b46bcdad70029e5865..44434e50a355fe898c175926dc640cb19ae89bef 100644 (file)
--- a/arch/mips/kernel/setup.c
+++ b/arch/mips/kernel/setup.c
@@ -1010,12 +1010,7 @@ unsigned long fw_passed_dtb;
 struct dentry *mips_debugfs_dir;
 static int __init debugfs_mips(void)
 {
-       struct dentry *d;
-
-       d = debugfs_create_dir("mips", NULL);
-       if (!d)
-               return -ENOMEM;
-       mips_debugfs_dir = d;
+       mips_debugfs_dir = debugfs_create_dir("mips", NULL);
        return 0;
 }
 arch_initcall(debugfs_mips);

diff --git a/arch/mips/kernel/spinlock_test.c b/arch/mips/kernel/spinlock_test.c
index eaed550e79a2efe7ee34c8587257704b3361c016..ab4e3e1b138d10f21ee4356c96ad2ee321c6dee0 100644 (file)
--- a/arch/mips/kernel/spinlock_test.c
+++ b/arch/mips/kernel/spinlock_test.c
@@ -118,23 +118,10 @@ DEFINE_SIMPLE_ATTRIBUTE(fops_multi, multi_get, NULL, "%llu\n");
 
 static int __init spinlock_test(void)
 {
-       struct dentry *d;
-
-       if (!mips_debugfs_dir)
-               return -ENODEV;
-
-       d = debugfs_create_file("spin_single", S_IRUGO,
-                               mips_debugfs_dir, NULL,
-                               &fops_ss);
-       if (!d)
-               return -ENOMEM;
-
-       d = debugfs_create_file("spin_multi", S_IRUGO,
-                               mips_debugfs_dir, NULL,
-                               &fops_multi);
-       if (!d)
-               return -ENOMEM;
-
+       debugfs_create_file("spin_single", S_IRUGO, mips_debugfs_dir, NULL,
+                           &fops_ss);
+       debugfs_create_file("spin_multi", S_IRUGO, mips_debugfs_dir, NULL,
+                           &fops_multi);
        return 0;
 }
 device_initcall(spinlock_test);

diff --git a/arch/mips/kernel/unaligned.c b/arch/mips/kernel/unaligned.c
index 595ca9c851110db0a76847f596ba21197db9aaf9..0ed20a64b28580035f6059d5da781505d0a1dea2 100644 (file)
--- a/arch/mips/kernel/unaligned.c
+++ b/arch/mips/kernel/unaligned.c
@@ -2374,18 +2374,10 @@ sigbus:
 #ifdef CONFIG_DEBUG_FS
 static int __init debugfs_unaligned(void)
 {
-       struct dentry *d;
-
-       if (!mips_debugfs_dir)
-               return -ENODEV;
-       d = debugfs_create_u32("unaligned_instructions", S_IRUGO,
-                              mips_debugfs_dir, &unaligned_instructions);
-       if (!d)
-               return -ENOMEM;
-       d = debugfs_create_u32("unaligned_action", S_IRUGO | S_IWUSR,
-                              mips_debugfs_dir, &unaligned_action);
-       if (!d)
-               return -ENOMEM;
+       debugfs_create_u32("unaligned_instructions", S_IRUGO, mips_debugfs_dir,
+                          &unaligned_instructions);
+       debugfs_create_u32("unaligned_action", S_IRUGO | S_IWUSR,
+                          mips_debugfs_dir, &unaligned_action);
        return 0;
 }
 arch_initcall(debugfs_unaligned);