]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
usb: dwc3: Remove dev_err() on platform_get_irq() failure
authorHans de Goede <hdegoede@redhat.com>
Sat, 5 Oct 2019 21:04:49 +0000 (23:04 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 7 Oct 2019 10:52:44 +0000 (12:52 +0200)
Since commit 7723f4c5ecdb ("driver core: platform: Add an error message to
platform_get_irq*()"), platform_get_irq() will call dev_err() itself on
failure, so there is no need for the driver to also do this.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Link: https://lore.kernel.org/r/20191005210449.3926-4-hdegoede@redhat.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/dwc3/drd.c
drivers/usb/dwc3/gadget.c
drivers/usb/dwc3/host.c

index b1f76628b31309d96f5f67fcab3f868fedcb737c..c946d64142ad77979908b9f54847790c13baa341 100644 (file)
@@ -157,9 +157,6 @@ static int dwc3_otg_get_irq(struct dwc3 *dwc)
        if (irq > 0)
                goto out;
 
-       if (irq != -EPROBE_DEFER)
-               dev_err(dwc->dev, "missing OTG IRQ\n");
-
        if (!irq)
                irq = -EINVAL;
 
index 13c97ff21dbab5641c2c6131120374a5ce5e1952..86dc1db788a9e5e02fa11b2564ed1c417f0b0d92 100644 (file)
@@ -3282,9 +3282,6 @@ static int dwc3_gadget_get_irq(struct dwc3 *dwc)
        if (irq > 0)
                goto out;
 
-       if (irq != -EPROBE_DEFER)
-               dev_err(dwc->dev, "missing peripheral IRQ\n");
-
        if (!irq)
                irq = -EINVAL;
 
index 534a49609779a5f7a54f84248069ace831963aa9..5567ed2cddbec278a1565216c07ac0a6fff475bc 100644 (file)
@@ -34,9 +34,6 @@ static int dwc3_host_get_irq(struct dwc3 *dwc)
        if (irq > 0)
                goto out;
 
-       if (irq != -EPROBE_DEFER)
-               dev_err(dwc->dev, "missing host IRQ\n");
-
        if (!irq)
                irq = -EINVAL;