]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
scsi: wd719x: make card_types static const, shrinks object size
authorColin Ian King <colin.king@canonical.com>
Tue, 28 Nov 2017 18:12:34 +0000 (18:12 +0000)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 5 Dec 2017 01:32:55 +0000 (20:32 -0500)
Don't populate the read-only array card_types on the stack but instead
make it static and constify it. Makes the object code smaller by over
110 bytes:

Before:
   text    data     bss     dec     hex filename
  25625    5752       0   31377    7a91 drivers/scsi/wd719x.o

After:
   text    data     bss     dec     hex filename
  25447    5816       0   31263    7a1f drivers/scsi/wd719x.o

(gcc version 7.2.0 x86_64)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/wd719x.c

index 2a9da2e0ea6baf7448be18120191ec7a4041aaa4..2ba2b7b47f4176285d04a2ebe0d94c53b6b63a18 100644 (file)
@@ -803,7 +803,9 @@ static enum wd719x_card_type wd719x_detect_type(struct wd719x *wd)
 static int wd719x_board_found(struct Scsi_Host *sh)
 {
        struct wd719x *wd = shost_priv(sh);
-       char *card_types[] = { "Unknown card", "WD7193", "WD7197", "WD7296" };
+       static const char * const card_types[] = {
+               "Unknown card", "WD7193", "WD7197", "WD7296"
+       };
        int ret;
 
        INIT_LIST_HEAD(&wd->active_scbs);