USB: serial: ti_usb_3410_5052: use functions rather than macros

Functions are preferable to macros resembling functions.

Signed-off-by: Mathieu OTHACEHE <m.othacehe@gmail.com>
[johan: drop inline keyword, move above calling function ]
Signed-off-by: Johan Hovold <johan@kernel.org>

diff --git a/drivers/usb/serial/ti_usb_3410_5052.c b/drivers/usb/serial/ti_usb_3410_5052.c
index 6002e8bfc9acd3053186eb0591a049741b0a37b9..07b4bf01061d86a6aafcdbb9d7ee7b6d331b9a05 100644 (file)
--- a/drivers/usb/serial/ti_usb_3410_5052.c
+++ b/drivers/usb/serial/ti_usb_3410_5052.c
@@ -248,8 +248,6 @@ struct ti_interrupt {
 } __packed;
 
 /* Interrupt codes */
-#define TI_GET_PORT_FROM_CODE(c)       (((c) >> 4) - 3)
-#define TI_GET_FUNC_FROM_CODE(c)       ((c) & 0x0f)
 #define TI_CODE_HARDWARE_ERROR         0xFF
 #define TI_CODE_DATA_ERROR             0x03
 #define TI_CODE_MODEM_STATUS           0x04
@@ -1168,6 +1166,15 @@ static void ti_break(struct tty_struct *tty, int break_state)
                dev_dbg(&port->dev, "%s - error setting break, %d\n", __func__, status);
 }
 
+static int ti_get_port_from_code(unsigned char code)
+{
+       return (code >> 4) - 3;
+}
+
+static int ti_get_func_from_code(unsigned char code)
+{
+       return code & 0x0f;
+}
 
 static void ti_interrupt_callback(struct urb *urb)
 {
@@ -1209,8 +1216,8 @@ static void ti_interrupt_callback(struct urb *urb)
                goto exit;
        }
 
-       port_number = TI_GET_PORT_FROM_CODE(data[0]);
-       function = TI_GET_FUNC_FROM_CODE(data[0]);
+       port_number = ti_get_port_from_code(data[0]);
+       function = ti_get_func_from_code(data[0]);
 
        dev_dbg(dev, "%s - port_number %d, function %d, data 0x%02X\n",
                __func__, port_number, function, data[1]);