]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
arm64: dts: imx8mq: correct interrupt flags
authorKrzysztof Kozlowski <krzk@kernel.org>
Thu, 17 Sep 2020 18:54:49 +0000 (20:54 +0200)
committerShawn Guo <shawnguo@kernel.org>
Tue, 22 Sep 2020 09:06:04 +0000 (17:06 +0800)
GPIO_ACTIVE_x flags are not correct in the context of interrupt flags.
These are simple defines so they could be used in DTS but they will not
have the same meaning:
1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE
2. GPIO_ACTIVE_LOW  = 1 = IRQ_TYPE_EDGE_RISING

Correct the interrupt flags, assuming the author of the code wanted same
logical behavior behind the name "ACTIVE_xxx", this is:
  ACTIVE_LOW  => IRQ_TYPE_LEVEL_LOW

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-By: Tim Harvey <tharvey@gateworks.com>
Signed-off-by: Shawn Guo <shawnguo@kernel.org>
arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
arch/arm64/boot/dts/freescale/imx8mq-phanbell.dts
arch/arm64/boot/dts/freescale/imx8mq-pico-pi.dts

index cce1b595e2d6e3b105aed011301783cab24986f5..af139b283daf6b07be65d2a65ec0f15323ed4aca 100644 (file)
@@ -6,6 +6,7 @@
 /dts-v1/;
 
 #include "dt-bindings/input/input.h"
+#include <dt-bindings/interrupt-controller/irq.h>
 #include "dt-bindings/pwm/pwm.h"
 #include "dt-bindings/usb/pd.h"
 #include "imx8mq.dtsi"
@@ -60,7 +61,7 @@
                        label = "WWAN_WAKE";
                        gpios = <&gpio3 8 GPIO_ACTIVE_LOW>;
                        interrupt-parent = <&gpio3>;
-                       interrupts = <8 GPIO_ACTIVE_LOW>;
+                       interrupts = <8 IRQ_TYPE_LEVEL_LOW>;
                        wakeup-source;
                        linux,code = <KEY_PHONE>;
                };
                #clock-cells = <0>;
                clock-output-names = "pmic_clk";
                interrupt-parent = <&gpio1>;
-               interrupts = <3 GPIO_ACTIVE_LOW>;
+               interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
                rohm,reset-snvs-powered;
 
                regulators {
index 56295dd2fa8ffe53575aa7e953f10695da515195..0c13b70192afd5f7ced2ceb5e7efabe01c326faf 100644 (file)
@@ -6,6 +6,7 @@
 /dts-v1/;
 
 #include "dt-bindings/input/input.h"
+#include <dt-bindings/interrupt-controller/irq.h>
 #include "dt-bindings/pwm/pwm.h"
 #include "dt-bindings/usb/pd.h"
 #include "imx8mq.dtsi"
                clock-names = "osc";
                clock-output-names = "pmic_clk";
                interrupt-parent = <&gpio1>;
-               interrupts = <7 GPIO_ACTIVE_LOW>;
+               interrupts = <7 IRQ_TYPE_LEVEL_LOW>;
                rohm,reset-snvs-powered;
 
                regulators {
index d6d3a3d5abc38f59c6e2fb81519185dffe4c2bff..a3b9d615a3b4076b8b346af41342d7b8b524d6d8 100644 (file)
@@ -6,6 +6,7 @@
 /dts-v1/;
 
 #include "imx8mq.dtsi"
+#include <dt-bindings/interrupt-controller/irq.h>
 
 / {
        model = "Google i.MX8MQ Phanbell";
                clocks = <&pmic_osc>;
                clock-output-names = "pmic_clk";
                interrupt-parent = <&gpio1>;
-               interrupts = <3 GPIO_ACTIVE_LOW>;
+               interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
 
                regulators {
                        buck1: BUCK1 {
index f4d5748a7bd6c11e6eb082497e0985cdc06f8841..89cbec5c41b2176b80c6f73368f3e445bdd48967 100644 (file)
@@ -9,6 +9,7 @@
 /dts-v1/;
 
 #include "imx8mq.dtsi"
+#include <dt-bindings/interrupt-controller/irq.h>
 
 / {
        model = "TechNexion PICO-PI-8M";
@@ -70,7 +71,7 @@
                clock-names = "osc";
                clock-output-names = "pmic_clk";
                interrupt-parent = <&gpio1>;
-               interrupts = <3 GPIO_ACTIVE_LOW>;
+               interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
                interrupt-names = "irq";
 
                regulators {