]> git.proxmox.com Git - mirror_qemu.git/commitdiff
vfio: Fix broken EEH
authorGavin Shan <gwshan@linux.vnet.ibm.com>
Wed, 15 Jun 2016 04:28:27 +0000 (14:28 +1000)
committerDavid Gibson <david@gibson.dropbear.id.au>
Fri, 17 Jun 2016 05:59:18 +0000 (15:59 +1000)
vfio_eeh_container_op() is the backend that communicates with
host kernel to support EEH functionality in QEMU. However, the
functon should return the value from host kernel instead of 0
unconditionally.

dwg: Specifically the problem occurs for the handful of EEH
sub-operations which can return a non-zero, non-error result.

Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
Acked-by: Alex Williamson <alex.williamson@redhat.com>
[dwg: clarification to commit message]
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
hw/vfio/common.c

index 5ff5e9220ac0902ec91bdc6d469309c096dcc177..1898f1f3e431b14362ae5eab49c9da85ccf4e1c7 100644 (file)
@@ -1257,7 +1257,7 @@ static int vfio_eeh_container_op(VFIOContainer *container, uint32_t op)
         return -errno;
     }
 
-    return 0;
+    return ret;
 }
 
 static VFIOContainer *vfio_eeh_as_container(AddressSpace *as)