]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
spi: fsl-lpspi: quit reading rx fifo under error condition
authorGao Pan <pandy.gao@nxp.com>
Fri, 2 Dec 2016 03:50:01 +0000 (11:50 +0800)
committerMark Brown <broonie@kernel.org>
Mon, 5 Dec 2016 11:45:03 +0000 (11:45 +0000)
In case that error occurs during waiting for txfifo empty, it is
not necessary to read rx fifo. It's better to return directly.

Signed-off-by: Gao Pan <pandy.gao@nxp.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-fsl-lpspi.c

index c4a4e2622a5340a51c7e70ca68496fa96bd950bc..52551f6d0c7ddf71aaf03ecc18c5caf2f804108b 100644 (file)
@@ -350,9 +350,12 @@ static int fsl_lpspi_transfer_one(struct spi_master *master,
        }
 
        ret = fsl_lpspi_txfifo_empty(fsl_lpspi);
+       if (ret)
+               return ret;
+
        fsl_lpspi_read_rx_fifo(fsl_lpspi);
 
-       return ret;
+       return 0;
 }
 
 static int fsl_lpspi_transfer_one_msg(struct spi_master *master,