]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
ion: improve ion_phys error message
authorMitchel Humpherys <mitchelh@codeaurora.org>
Sat, 14 Feb 2015 02:05:34 +0000 (18:05 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 20 Mar 2015 12:44:39 +0000 (13:44 +0100)
Clients often get confused when ion_phys errors out due to some heap
being used that they didn't expect.  Add the heap name and heap type to
the error message to make it more obvious.

Signed-off-by: Mitchel Humpherys <mitchelh@codeaurora.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/android/ion/ion.c

index 65361ca33fc9c8ac7efab74c6892ecccea0cf80a..0e3d8c7add24e1955e2bd480075df0caf09b1a94 100644 (file)
@@ -566,8 +566,8 @@ int ion_phys(struct ion_client *client, struct ion_handle *handle,
        buffer = handle->buffer;
 
        if (!buffer->heap->ops->phys) {
-               pr_err("%s: ion_phys is not implemented by this heap.\n",
-                      __func__);
+               pr_err("%s: ion_phys is not implemented by this heap (name=%s, type=%d).\n",
+                       __func__, buffer->heap->name, buffer->heap->type);
                mutex_unlock(&client->lock);
                return -ENODEV;
        }