media: drxk_hard: check if parameter is not NULL

There is a smatch warning:
	drivers/media/dvb-frontends/drxk_hard.c: drivers/media/dvb-frontends/drxk_hard.c:1478 scu_command() error: we previously assumed 'parameter' could be null (see line 1467)

Telling that parameter might be NULL. Well, it can't, due to the
way the driver works, but it doesn't hurt to add a check, in order
to shut up smatch.

Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>

diff --git a/drivers/media/dvb-frontends/drxk_hard.c b/drivers/media/dvb-frontends/drxk_hard.c
index 84ac3f73f8fe4859c7f73f81b8fac1266b2c8240..8ea1e45be710736d13030beb5b93a769eab6b45f 100644 (file)
--- a/drivers/media/dvb-frontends/drxk_hard.c
+++ b/drivers/media/dvb-frontends/drxk_hard.c
@@ -1474,9 +1474,11 @@ static int scu_command(struct drxk_state *state,
 
        /* assume that the command register is ready
                since it is checked afterwards */
-       for (ii = parameter_len - 1; ii >= 0; ii -= 1) {
-               buffer[cnt++] = (parameter[ii] & 0xFF);
-               buffer[cnt++] = ((parameter[ii] >> 8) & 0xFF);
+       if (parameter) {
+               for (ii = parameter_len - 1; ii >= 0; ii -= 1) {
+                       buffer[cnt++] = (parameter[ii] & 0xFF);
+                       buffer[cnt++] = ((parameter[ii] >> 8) & 0xFF);
+               }
        }
        buffer[cnt++] = (cmd & 0xFF);
        buffer[cnt++] = ((cmd >> 8) & 0xFF);