]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
regmap: fix bulk writes on paged registers
authorSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Wed, 12 Jun 2019 11:03:43 +0000 (12:03 +0100)
committerMark Brown <broonie@kernel.org>
Wed, 12 Jun 2019 12:56:06 +0000 (13:56 +0100)
On buses like SlimBus and SoundWire which does not support
gather_writes yet in regmap, A bulk write on paged register
would be silently ignored after programming page.
This is because local variable 'ret' value in regmap_raw_write_impl()
gets reset to 0 once page register is written successfully and the
code below checks for 'ret' value to be -ENOTSUPP before linearising
the write buffer to send to bus->write().

Fix this by resetting the 'ret' value to -ENOTSUPP in cases where
gather_writes() is not supported or single register write is
not possible.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/base/regmap/regmap.c

index f1025452bb394675ed5c86fdcbcf07285902068a..19f57ccfbe1d71478f769cf886b5efecd11b19da 100644 (file)
@@ -1637,6 +1637,8 @@ static int _regmap_raw_write_impl(struct regmap *map, unsigned int reg,
                                             map->format.reg_bytes +
                                             map->format.pad_bytes,
                                             val, val_len);
+       else
+               ret = -ENOTSUPP;
 
        /* If that didn't work fall back on linearising by hand. */
        if (ret == -ENOTSUPP) {