]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
staging: spmi: hisi-spmi-controller: Use devm_ version of ioremap().
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 18 Sep 2020 14:33:38 +0000 (17:33 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 22 Sep 2020 07:49:34 +0000 (09:49 +0200)
The ioremap() was never unmapped in the probe error handling or in the
remove function.  The fix is to use the devm_ioremap() function so it
gets cleaned up automatically.

Fixes: 70f59c90c819 ("staging: spmi: add Hikey 970 SPMI controller driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20200918143338.GE909725@mwanda
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/hikey9xx/hisi-spmi-controller.c

index 5ffe79f45d9af33cfa963658daa8dd7e10566505..f831c43f4783f1b2cafc6b4f73024f089c463dd2 100644 (file)
@@ -281,7 +281,8 @@ static int spmi_controller_probe(struct platform_device *pdev)
                return -EINVAL;
        }
 
-       spmi_controller->base = ioremap(iores->start, resource_size(iores));
+       spmi_controller->base = devm_ioremap(&pdev->dev, iores->start,
+                                            resource_size(iores));
        if (!spmi_controller->base) {
                dev_err(&pdev->dev, "can not remap base addr!\n");
                return -EADDRNOTAVAIL;