]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
power: supply: cpcap-battery: Fix division by zero
authorTony Lindgren <tony@atomide.com>
Sun, 7 Apr 2019 18:12:48 +0000 (11:12 -0700)
committerSebastian Reichel <sre@kernel.org>
Tue, 9 Apr 2019 22:53:20 +0000 (00:53 +0200)
If called fast enough so samples do not increment, we can get
division by zero in kernel:

__div0
cpcap_battery_cc_raw_div
cpcap_battery_get_property
power_supply_get_property.part.1
power_supply_get_property
power_supply_show_property
power_supply_uevent

Fixes: 874b2adbed12 ("power: supply: cpcap-battery: Add a battery driver")
Signed-off-by: Tony Lindgren <tony@atomide.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
drivers/power/supply/cpcap-battery.c

index 08d5037fd0521523dcfb5d9ce211a117b2ff52e9..6887870ba32c38b075145500b173052f45226206 100644 (file)
@@ -221,6 +221,9 @@ static int cpcap_battery_cc_raw_div(struct cpcap_battery_ddata *ddata,
        int avg_current;
        u32 cc_lsb;
 
+       if (!divider)
+               return 0;
+
        sample &= 0xffffff;             /* 24-bits, unsigned */
        offset &= 0x7ff;                /* 10-bits, signed */