]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
net: calxedaxgmac: fix rx ring handling when OOM
authorRob Herring <rob.herring@calxeda.com>
Thu, 28 Mar 2013 11:32:44 +0000 (11:32 +0000)
committerDavid S. Miller <davem@davemloft.net>
Fri, 29 Mar 2013 19:29:35 +0000 (15:29 -0400)
If skb allocation for the rx ring fails repeatedly, we can reach a point
were the ring is empty. In this condition, the driver is out of sync with
the h/w. While this has always been possible, the removal of the skb
recycling seems to have made triggering this problem easier.

Signed-off-by: Rob Herring <rob.herring@calxeda.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/calxeda/xgmac.c

index a170065b597382ed9408239d98c36cec98a535a2..bb1e80bfa78a4a9f333639e3d452ecd15e8b3fa0 100644 (file)
@@ -1141,6 +1141,9 @@ static int xgmac_rx(struct xgmac_priv *priv, int limit)
                struct sk_buff *skb;
                int frame_len;
 
+               if (!dma_ring_cnt(priv->rx_head, priv->rx_tail, DMA_RX_RING_SZ))
+                       break;
+
                entry = priv->rx_tail;
                p = priv->dma_rx + entry;
                if (desc_get_owner(p))