]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
drm/arc: Remove sending of vblank event
authorThomas Zimmermann <tzimmermann@suse.de>
Wed, 29 Jan 2020 12:05:18 +0000 (13:05 +0100)
committerThomas Zimmermann <tzimmermann@suse.de>
Thu, 30 Jan 2020 07:57:22 +0000 (08:57 +0100)
The atomic helpers automatically send out fake VBLANK events if no
vblanking has been initialized. Remove the sending code from the
driver.

v4:
* separate commit from core vblank changes

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20200129120531.6891-3-tzimmermann@suse.de
drivers/gpu/drm/arc/arcpgu_crtc.c

index 8ae1e1f97a735a40391adb2e772b0ba19f4dde58..be7c29cec318d13fc45562a1c169d6de98b03b9e 100644 (file)
@@ -9,7 +9,6 @@
 #include <drm/drm_device.h>
 #include <drm/drm_fb_cma_helper.h>
 #include <drm/drm_gem_cma_helper.h>
-#include <drm/drm_vblank.h>
 #include <drm/drm_plane_helper.h>
 #include <drm/drm_probe_helper.h>
 #include <linux/clk.h>
@@ -138,24 +137,9 @@ static void arc_pgu_crtc_atomic_disable(struct drm_crtc *crtc,
                              ~ARCPGU_CTRL_ENABLE_MASK);
 }
 
-static void arc_pgu_crtc_atomic_begin(struct drm_crtc *crtc,
-                                     struct drm_crtc_state *state)
-{
-       struct drm_pending_vblank_event *event = crtc->state->event;
-
-       if (event) {
-               crtc->state->event = NULL;
-
-               spin_lock_irq(&crtc->dev->event_lock);
-               drm_crtc_send_vblank_event(crtc, event);
-               spin_unlock_irq(&crtc->dev->event_lock);
-       }
-}
-
 static const struct drm_crtc_helper_funcs arc_pgu_crtc_helper_funcs = {
        .mode_valid     = arc_pgu_crtc_mode_valid,
        .mode_set_nofb  = arc_pgu_crtc_mode_set_nofb,
-       .atomic_begin   = arc_pgu_crtc_atomic_begin,
        .atomic_enable  = arc_pgu_crtc_atomic_enable,
        .atomic_disable = arc_pgu_crtc_atomic_disable,
 };