]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
rtc: rtc-test: use devm_rtc_device_register()
authorJingoo Han <jg1.han@samsung.com>
Mon, 29 Apr 2013 23:19:52 +0000 (16:19 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 30 Apr 2013 01:28:31 +0000 (18:28 -0700)
devm_rtc_device_register() is device managed and makes cleanup paths
simpler.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/rtc/rtc-test.c

index b92e0f6383e6bac3549e45310d1c78478216205e..7746e65b93f290aab1db8c422d997d38962ac5ff 100644 (file)
@@ -99,8 +99,10 @@ static DEVICE_ATTR(irq, S_IRUGO | S_IWUSR, test_irq_show, test_irq_store);
 static int test_probe(struct platform_device *plat_dev)
 {
        int err;
-       struct rtc_device *rtc = rtc_device_register("test", &plat_dev->dev,
-                                               &test_rtc_ops, THIS_MODULE);
+       struct rtc_device *rtc;
+
+       rtc = devm_rtc_device_register(&plat_dev->dev, "test",
+                               &test_rtc_ops, THIS_MODULE);
        if (IS_ERR(rtc)) {
                err = PTR_ERR(rtc);
                return err;
@@ -115,15 +117,11 @@ static int test_probe(struct platform_device *plat_dev)
        return 0;
 
 err:
-       rtc_device_unregister(rtc);
        return err;
 }
 
 static int test_remove(struct platform_device *plat_dev)
 {
-       struct rtc_device *rtc = platform_get_drvdata(plat_dev);
-
-       rtc_device_unregister(rtc);
        device_remove_file(&plat_dev->dev, &dev_attr_irq);
 
        return 0;