]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
perf tools: Fix handling of wildcards in tracepoint event selectors
authorArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 17 Jan 2011 16:25:06 +0000 (14:25 -0200)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 17 Jan 2011 17:26:07 +0000 (15:26 -0200)
It wasn't accounting the ':' when consuming bytes in the the event
selector string, so parse_events() would fail in this test:

                if (!(*str == 0 || *str == ',' || isspace(*str)))
                        return -1;

as *str would be pointing to '*', the last character in the '-e' arg in:

$ perf record -q -a -D -e sched:sched_* | perf script -i - -s perf-script.py

Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Tom Zanussi <tzanussi@gmail.com>
LKML-Reference: <new-submission>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/parse-events.c

index 5cb6f4bde9055b84c202970cd39b86ce7f144f54..1f4cfe5d32fc9db5aa40a1590e4803eecd570583 100644 (file)
@@ -555,7 +555,7 @@ static enum event_result parse_tracepoint_event(const char **strp,
        if (evt_length >= MAX_EVENT_LENGTH)
                return EVT_FAILED;
        if (strpbrk(evt_name, "*?")) {
-               *strp += strlen(sys_name) + evt_length;
+               *strp += strlen(sys_name) + evt_length + 1; /* 1 == the ':' */
                return parse_multiple_tracepoint_event(sys_name, evt_name,
                                                       flags);
        } else {