i2c: mlxbf: add IRQ check

BugLink: https://bugs.launchpad.net/bugs/1929455
[ Upstream commit 0d3bf53e897dce943b98d975bbde77156af6cd81 ]

The driver neglects to check the result of platform_get_irq()'s call and
blithely passes the negative error codes to devm_request_irq() (which
takes *unsigned* IRQ #), causing it to fail with -EINVAL, overriding
an original error code.  Stop calling devm_request_irq() with invalid
IRQ #s.

Fixes: b5b5b32081cd ("i2c: mlxbf: I2C SMBus driver for Mellanox BlueField SoC")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omprussia.ru>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kelsey Skunberg <kelsey.skunberg@canonical.com>

diff --git a/drivers/i2c/busses/i2c-mlxbf.c b/drivers/i2c/busses/i2c-mlxbf.c
index 2fb0532d8a1611591221cf226d96bd963d69b0d1..ab261d762dea3bfc9b51ffa89748425bb0b8c030 100644 (file)
--- a/drivers/i2c/busses/i2c-mlxbf.c
+++ b/drivers/i2c/busses/i2c-mlxbf.c
@@ -2376,6 +2376,8 @@ static int mlxbf_i2c_probe(struct platform_device *pdev)
        mlxbf_i2c_init_slave(pdev, priv);
 
        irq = platform_get_irq(pdev, 0);
+       if (irq < 0)
+               return irq;
        ret = devm_request_irq(dev, irq, mlxbf_smbus_irq,
                               IRQF_ONESHOT | IRQF_SHARED | IRQF_PROBE_SHARED,
                               dev_name(dev), priv);