]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commitdiff
powerpc/ppc64: Rename SOFT_DISABLE_INTS with RECONCILE_IRQ_STATE
authorTiejun Chen <tiejun.chen@windriver.com>
Tue, 16 Jul 2013 03:09:30 +0000 (11:09 +0800)
committerBenjamin Herrenschmidt <benh@kernel.crashing.org>
Wed, 14 Aug 2013 04:57:47 +0000 (14:57 +1000)
The SOFT_DISABLE_INTS seems an odd name for something that updates the
software state to be consistent with interrupts being hard disabled, so
rename SOFT_DISABLE_INTS with RECONCILE_IRQ_STATE to avoid this confusion.

Signed-off-by: Tiejun Chen <tiejun.chen@windriver.com>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
arch/powerpc/include/asm/exception-64s.h
arch/powerpc/include/asm/irqflags.h
arch/powerpc/kernel/entry_64.S
arch/powerpc/kernel/exceptions-64e.S

index 07ca627e52c0b25ed45fb61128b3dc2210a4f541..4834a6d5a75cc4e71005ce366e8cb82b5820625b 100644 (file)
@@ -479,7 +479,7 @@ label##_relon_hv:                                                   \
  */
 
 /* Exception addition: Hard disable interrupts */
-#define DISABLE_INTS   SOFT_DISABLE_INTS(r10,r11)
+#define DISABLE_INTS   RECONCILE_IRQ_STATE(r10,r11)
 
 #define ADD_NVGPRS                             \
        bl      .save_nvgprs
index 6f9b6e23dc5af74c8ee1423b052d2ada384c3d36..f51a5580bfd0b2dfbe1abb5edd68e5ab2d3541b7 100644 (file)
 #define TRACE_DISABLE_INTS     TRACE_WITH_FRAME_BUFFER(.trace_hardirqs_off)
 
 /*
- * This is used by assembly code to soft-disable interrupts
+ * This is used by assembly code to soft-disable interrupts first and
+ * reconcile irq state.
  */
-#define SOFT_DISABLE_INTS(__rA, __rB)          \
+#define RECONCILE_IRQ_STATE(__rA, __rB)                \
        lbz     __rA,PACASOFTIRQEN(r13);        \
        lbz     __rB,PACAIRQHAPPENED(r13);      \
        cmpwi   cr0,__rA,0;                     \
@@ -58,7 +59,7 @@
 #define TRACE_ENABLE_INTS
 #define TRACE_DISABLE_INTS
 
-#define SOFT_DISABLE_INTS(__rA, __rB)          \
+#define RECONCILE_IRQ_STATE(__rA, __rB)                \
        lbz     __rA,PACAIRQHAPPENED(r13);      \
        li      __rB,0;                         \
        ori     __rA,__rA,PACA_IRQ_HARD_DIS;    \
index ab15b8d057ad361f609b06277eb0a993574098cd..c1055a150b88c1ca3cc8c434bd0db3c3d53717f7 100644 (file)
@@ -721,9 +721,9 @@ resume_kernel:
 
        /*
         * Here we are preempting the current task. We want to make
-        * sure we are soft-disabled first
+        * sure we are soft-disabled first and reconcile irq state.
         */
-       SOFT_DISABLE_INTS(r3,r4)
+       RECONCILE_IRQ_STATE(r3,r4)
 1:     bl      .preempt_schedule_irq
 
        /* Re-test flags and eventually loop */
index 645170a07ada1da7abf4fddc814fcbaad9c071c9..2d067049db27f1e56ca421c0a223e958125f60ad 100644 (file)
@@ -198,9 +198,9 @@ exc_##n##_common:                                                       \
 /* This second version is meant for exceptions that don't immediately
  * hard-enable. We set a bit in paca->irq_happened to ensure that
  * a subsequent call to arch_local_irq_restore() will properly
- * hard-enable and avoid the fast-path
+ * hard-enable and avoid the fast-path, and then reconcile irq state.
  */
-#define INTS_DISABLE   SOFT_DISABLE_INTS(r3,r4)
+#define INTS_DISABLE   RECONCILE_IRQ_STATE(r3,r4)
 
 /* This is called by exceptions that used INTS_KEEP (that did not touch
  * irq indicators in the PACA). This will restore MSR:EE to it's previous