]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
net: fix a new kernel-doc warning at dev.c
authorMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Tue, 22 Sep 2020 11:22:52 +0000 (13:22 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 24 Sep 2020 00:42:54 +0000 (17:42 -0700)
kernel-doc expects the function prototype to be just after
the kernel-doc markup, as otherwise it will get it all wrong:

./net/core/dev.c:10036: warning: Excess function parameter 'dev' description in 'WAIT_REFS_MIN_MSECS'

Fixes: 0e4be9e57e8c ("net: use exponential backoff in netdev_wait_allrefs")
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Reviewed-by: Francesco Ruggeri <fruggeri@arista.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/dev.c

index a268ff35ad38e95f288ca39e59400502d3d92cce..873b50ac9668ec2753b53ab118a7a316169e9d3a 100644 (file)
@@ -10021,6 +10021,8 @@ int netdev_refcnt_read(const struct net_device *dev)
 }
 EXPORT_SYMBOL(netdev_refcnt_read);
 
+#define WAIT_REFS_MIN_MSECS 1
+#define WAIT_REFS_MAX_MSECS 250
 /**
  * netdev_wait_allrefs - wait until all references are gone.
  * @dev: target net_device
@@ -10033,8 +10035,6 @@ EXPORT_SYMBOL(netdev_refcnt_read);
  * We can get stuck here if buggy protocols don't correctly
  * call dev_put.
  */
-#define WAIT_REFS_MIN_MSECS 1
-#define WAIT_REFS_MAX_MSECS 250
 static void netdev_wait_allrefs(struct net_device *dev)
 {
        unsigned long rebroadcast_time, warning_time;