xfs: Check for -ENOATTR or -EEXIST

Delayed operations cannot return error codes.  So we must check for
these conditions first before starting set or remove operations

Signed-off-by: Allison Collins <allison.henderson@oracle.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Acked-by: Dave Chinner <dchinner@redhat.com>

diff --git a/fs/xfs/libxfs/xfs_attr.c b/fs/xfs/libxfs/xfs_attr.c
index f7f796ea11fdefc3e7d686707e0a3861c4c3a31f..1618efda033232e79c3a8daade00368aa7fe81e8 100644 (file)
--- a/fs/xfs/libxfs/xfs_attr.c
+++ b/fs/xfs/libxfs/xfs_attr.c
@@ -404,6 +404,15 @@ xfs_attr_set(
                                args->total, 0, quota_flags);
                if (error)
                        goto out_trans_cancel;
+
+               error = xfs_has_attr(args);
+               if (error == -EEXIST && (args->attr_flags & XATTR_CREATE))
+                       goto out_trans_cancel;
+               if (error == -ENOATTR && (args->attr_flags & XATTR_REPLACE))
+                       goto out_trans_cancel;
+               if (error != -ENOATTR && error != -EEXIST)
+                       goto out_trans_cancel;
+
                error = xfs_attr_set_args(args);
                if (error)
                        goto out_trans_cancel;
@@ -411,6 +420,10 @@ xfs_attr_set(
                if (!args->trans)
                        goto out_unlock;
        } else {
+               error = xfs_has_attr(args);
+               if (error != -EEXIST)
+                       goto out_trans_cancel;
+
                error = xfs_attr_remove_args(args);
                if (error)
                        goto out_trans_cancel;