]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commitdiff
vfs: Pass setxattr(2) flags properly
authorJan Kara <jack@suse.cz>
Wed, 20 Apr 2011 18:30:40 +0000 (20:30 +0200)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 21 Apr 2011 14:34:44 +0000 (07:34 -0700)
For some reason generic_setxattr() did not pass flags (XATTR_CREATE,
XATTR_REPLACE) to the filesystem specific helper. This caused that
setxattr(2) syscall just ignored these flags.

Fix the bug by passing flags correctly.

Signed-off-by: Jan Kara <jack@suse.cz>
Acked-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/xattr.c

index a19acdb81cd1270c174711c851b17013edb9ca80..f1ef94974dea12f10beceff4a12899851ba7aeab 100644 (file)
@@ -666,7 +666,7 @@ generic_setxattr(struct dentry *dentry, const char *name, const void *value, siz
        handler = xattr_resolve_name(dentry->d_sb->s_xattr, &name);
        if (!handler)
                return -EOPNOTSUPP;
-       return handler->set(dentry, name, value, size, 0, handler->flags);
+       return handler->set(dentry, name, value, size, flags, handler->flags);
 }
 
 /*