]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
sata_rcar: clear STOP bit in bmdma_start() method
authorSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Tue, 21 May 2013 19:07:54 +0000 (23:07 +0400)
committerTejun Heo <tj@kernel.org>
Tue, 21 May 2013 23:39:20 +0000 (08:39 +0900)
Iff bmdma_setup() has to stop a DMA transfer before starting a new
one, then the STOP bit in the ATAPI_CONTROL1 register will remain set
(it's only cleared when setting the START bit to 1) and then
bmdma_start() method will set both START and STOP bits simultaneously
which should abort the transfer being just started.  Avoid that by
explicitly clearing the STOP bit in bmdma_start() method (in this case
it will be ignored on write).

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: stable@vger.kernel.org
drivers/ata/sata_rcar.c

index 4799868bd7339c40ad863a317e92e2d0ddfffe9a..a8e091aafddef381307360164fcc91471f2ad2d6 100644 (file)
@@ -549,6 +549,7 @@ static void sata_rcar_bmdma_start(struct ata_queued_cmd *qc)
 
        /* start host DMA transaction */
        dmactl = ioread32(priv->base + ATAPI_CONTROL1_REG);
+       dmactl &= ~ATAPI_CONTROL1_STOP;
        dmactl |= ATAPI_CONTROL1_START;
        iowrite32(dmactl, priv->base + ATAPI_CONTROL1_REG);
 }