]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
media: ti-vpe: cal: Reorder camerarx functions to prepare refactoring
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Mon, 6 Jul 2020 18:36:38 +0000 (20:36 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Sun, 19 Jul 2020 08:38:00 +0000 (10:38 +0200)
To prepare for the camerarx refactoring, reorder functions without any
functional change to ease review of the refactoring itself.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Benoit Parrot <bparrot@ti.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/platform/ti-vpe/cal.c

index 4be1fa7e819727895c656c7d53d92e0182f36ead..6b0ed2946eba862158cc343a4feb73390baa43a7 100644 (file)
@@ -481,6 +481,54 @@ static void cal_quickdump_regs(struct cal_dev *cal)
  * ------------------------------------------------------------------
  */
 
+static int cal_camerarx_get_external_info(struct cal_camerarx *phy)
+{
+       struct v4l2_ctrl *ctrl;
+
+       if (!phy->sensor)
+               return -ENODEV;
+
+       ctrl = v4l2_ctrl_find(phy->sensor->ctrl_handler, V4L2_CID_PIXEL_RATE);
+       if (!ctrl) {
+               phy_err(phy, "no pixel rate control in subdev: %s\n",
+                       phy->sensor->name);
+               return -EPIPE;
+       }
+
+       phy->external_rate = v4l2_ctrl_g_ctrl_int64(ctrl);
+       phy_dbg(3, phy, "sensor Pixel Rate: %u\n", phy->external_rate);
+
+       return 0;
+}
+
+static void cal_camerarx_lane_config(struct cal_camerarx *phy)
+{
+       u32 val = reg_read(phy->cal, CAL_CSI2_COMPLEXIO_CFG(phy->instance));
+       u32 lane_mask = CAL_CSI2_COMPLEXIO_CFG_CLOCK_POSITION_MASK;
+       u32 polarity_mask = CAL_CSI2_COMPLEXIO_CFG_CLOCK_POL_MASK;
+       struct v4l2_fwnode_bus_mipi_csi2 *mipi_csi2 =
+               &phy->endpoint.bus.mipi_csi2;
+       int lane;
+
+       set_field(&val, mipi_csi2->clock_lane + 1, lane_mask);
+       set_field(&val, mipi_csi2->lane_polarities[0], polarity_mask);
+       for (lane = 0; lane < mipi_csi2->num_data_lanes; lane++) {
+               /*
+                * Every lane are one nibble apart starting with the
+                * clock followed by the data lanes so shift masks by 4.
+                */
+               lane_mask <<= 4;
+               polarity_mask <<= 4;
+               set_field(&val, mipi_csi2->data_lanes[lane] + 1, lane_mask);
+               set_field(&val, mipi_csi2->lane_polarities[lane + 1],
+                         polarity_mask);
+       }
+
+       reg_write(phy->cal, CAL_CSI2_COMPLEXIO_CFG(phy->instance), val);
+       phy_dbg(3, phy, "CAL_CSI2_COMPLEXIO_CFG(%d) = 0x%08x\n",
+               phy->instance, val);
+}
+
 static void cal_camerarx_enable(struct cal_camerarx *phy)
 {
        u32 num_lanes = phy->cal->data->camerarx[phy->instance].num_lanes;
@@ -500,88 +548,53 @@ static void cal_camerarx_disable(struct cal_camerarx *phy)
 }
 
 /*
- *   Errata i913: CSI2 LDO Needs to be disabled when module is powered on
- *
- *   Enabling CSI2 LDO shorts it to core supply. It is crucial the 2 CSI2
- *   LDOs on the device are disabled if CSI-2 module is powered on
- *   (0x4845 B304 | 0x4845 B384 [28:27] = 0x1) or in ULPS (0x4845 B304
- *   | 0x4845 B384 [28:27] = 0x2) mode. Common concerns include: high
- *   current draw on the module supply in active mode.
- *
- *   Errata does not apply when CSI-2 module is powered off
- *   (0x4845 B304 | 0x4845 B384 [28:27] = 0x0).
- *
- * SW Workaround:
- *     Set the following register bits to disable the LDO,
- *     which is essentially CSI2 REG10 bit 6:
- *
- *             Core 0:  0x4845 B828 = 0x0000 0040
- *             Core 1:  0x4845 B928 = 0x0000 0040
+ * TCLK values are OK at their reset values
  */
-static void cal_camerarx_i913_errata(struct cal_camerarx *phy)
-{
-       u32 reg10 = reg_read(phy, CAL_CSI2_PHY_REG10);
-
-       set_field(&reg10, 1, CAL_CSI2_PHY_REG10_I933_LDO_DISABLE_MASK);
-
-       phy_dbg(1, phy, "CSI2_%d_REG10 = 0x%08x\n", phy->instance, reg10);
-       reg_write(phy, CAL_CSI2_PHY_REG10, reg10);
-}
+#define TCLK_TERM      0
+#define TCLK_MISS      1
+#define TCLK_SETTLE    14
 
-/*
- * Enable the expected IRQ sources
- */
-static void cal_camerarx_enable_irqs(struct cal_camerarx *phy)
+static void cal_camerarx_config(struct cal_camerarx *phy,
+                               const struct cal_fmt *fmt)
 {
-       u32 val;
+       unsigned int reg0, reg1;
+       unsigned int ths_term, ths_settle;
+       unsigned int csi2_ddrclk_khz;
+       struct v4l2_fwnode_bus_mipi_csi2 *mipi_csi2 =
+                       &phy->endpoint.bus.mipi_csi2;
+       u32 num_lanes = mipi_csi2->num_data_lanes;
 
-       const u32 cio_err_mask =
-               CAL_CSI2_COMPLEXIO_IRQ_LANE_ERRORS_MASK |
-               CAL_CSI2_COMPLEXIO_IRQ_FIFO_OVR_MASK |
-               CAL_CSI2_COMPLEXIO_IRQ_SHORT_PACKET_MASK |
-               CAL_CSI2_COMPLEXIO_IRQ_ECC_NO_CORRECTION_MASK;
+       /* DPHY timing configuration */
+       /* CSI-2 is DDR and we only count used lanes. */
+       csi2_ddrclk_khz = phy->external_rate / 1000
+               / (2 * num_lanes) * fmt->bpp;
+       phy_dbg(1, phy, "csi2_ddrclk_khz: %d\n", csi2_ddrclk_khz);
 
-       /* Enable CIO error irqs */
-       reg_write(phy->cal, CAL_HL_IRQENABLE_SET(0),
-                 CAL_HL_IRQ_CIO_MASK(phy->instance));
-       reg_write(phy->cal, CAL_CSI2_COMPLEXIO_IRQENABLE(phy->instance),
-                 cio_err_mask);
+       /* THS_TERM: Programmed value = floor(20 ns/DDRClk period) */
+       ths_term = 20 * csi2_ddrclk_khz / 1000000;
+       phy_dbg(1, phy, "ths_term: %d (0x%02x)\n", ths_term, ths_term);
 
-       /* Always enable OCPO error */
-       reg_write(phy->cal, CAL_HL_IRQENABLE_SET(0), CAL_HL_IRQ_OCPO_ERR_MASK);
+       /* THS_SETTLE: Programmed value = floor(105 ns/DDRClk period) + 4 */
+       ths_settle = (105 * csi2_ddrclk_khz / 1000000) + 4;
+       phy_dbg(1, phy, "ths_settle: %d (0x%02x)\n", ths_settle, ths_settle);
 
-       /* Enable IRQ_WDMA_END 0/1 */
-       val = 0;
-       set_field(&val, 1, CAL_HL_IRQ_MASK(phy->instance));
-       reg_write(phy->cal, CAL_HL_IRQENABLE_SET(1), val);
-       /* Enable IRQ_WDMA_START 0/1 */
-       val = 0;
-       set_field(&val, 1, CAL_HL_IRQ_MASK(phy->instance));
-       reg_write(phy->cal, CAL_HL_IRQENABLE_SET(2), val);
-       /* Todo: Add VC_IRQ and CSI2_COMPLEXIO_IRQ handling */
-       reg_write(phy->cal, CAL_CSI2_VC_IRQENABLE(0), 0xFF000000);
-}
+       reg0 = reg_read(phy, CAL_CSI2_PHY_REG0);
+       set_field(&reg0, CAL_CSI2_PHY_REG0_HSCLOCKCONFIG_DISABLE,
+                 CAL_CSI2_PHY_REG0_HSCLOCKCONFIG_MASK);
+       set_field(&reg0, ths_term, CAL_CSI2_PHY_REG0_THS_TERM_MASK);
+       set_field(&reg0, ths_settle, CAL_CSI2_PHY_REG0_THS_SETTLE_MASK);
 
-static void cal_camerarx_disable_irqs(struct cal_camerarx *phy)
-{
-       u32 val;
+       phy_dbg(1, phy, "CSI2_%d_REG0 = 0x%08x\n", phy->instance, reg0);
+       reg_write(phy, CAL_CSI2_PHY_REG0, reg0);
 
-       /* Disable CIO error irqs */
-       reg_write(phy->cal, CAL_HL_IRQENABLE_CLR(0),
-                 CAL_HL_IRQ_CIO_MASK(phy->instance));
-       reg_write(phy->cal, CAL_CSI2_COMPLEXIO_IRQENABLE(phy->instance),
-                 0);
+       reg1 = reg_read(phy, CAL_CSI2_PHY_REG1);
+       set_field(&reg1, TCLK_TERM, CAL_CSI2_PHY_REG1_TCLK_TERM_MASK);
+       set_field(&reg1, 0xb8, CAL_CSI2_PHY_REG1_DPHY_HS_SYNC_PATTERN_MASK);
+       set_field(&reg1, TCLK_MISS, CAL_CSI2_PHY_REG1_CTRLCLK_DIV_FACTOR_MASK);
+       set_field(&reg1, TCLK_SETTLE, CAL_CSI2_PHY_REG1_TCLK_SETTLE_MASK);
 
-       /* Disable IRQ_WDMA_END 0/1 */
-       val = 0;
-       set_field(&val, 1, CAL_HL_IRQ_MASK(phy->instance));
-       reg_write(phy->cal, CAL_HL_IRQENABLE_CLR(1), val);
-       /* Disable IRQ_WDMA_START 0/1 */
-       val = 0;
-       set_field(&val, 1, CAL_HL_IRQ_MASK(phy->instance));
-       reg_write(phy->cal, CAL_HL_IRQENABLE_CLR(2), val);
-       /* Todo: Add VC_IRQ and CSI2_COMPLEXIO_IRQ handling */
-       reg_write(phy->cal, CAL_CSI2_VC_IRQENABLE(0), 0);
+       phy_dbg(1, phy, "CSI2_%d_REG1 = 0x%08x\n", phy->instance, reg1);
+       reg_write(phy, CAL_CSI2_PHY_REG1, reg1);
 }
 
 static void cal_camerarx_power(struct cal_camerarx *phy, bool enable)
@@ -613,54 +626,63 @@ static void cal_camerarx_power(struct cal_camerarx *phy, bool enable)
                        enable ? "up" : "down");
 }
 
-/*
- * TCLK values are OK at their reset values
- */
-#define TCLK_TERM      0
-#define TCLK_MISS      1
-#define TCLK_SETTLE    14
-
-static void cal_camerarx_config(struct cal_camerarx *phy,
-                               const struct cal_fmt *fmt)
+static void cal_camerarx_wait_reset(struct cal_camerarx *phy)
 {
-       unsigned int reg0, reg1;
-       unsigned int ths_term, ths_settle;
-       unsigned int csi2_ddrclk_khz;
-       struct v4l2_fwnode_bus_mipi_csi2 *mipi_csi2 =
-                       &phy->endpoint.bus.mipi_csi2;
-       u32 num_lanes = mipi_csi2->num_data_lanes;
+       unsigned long timeout;
 
-       /* DPHY timing configuration */
-       /* CSI-2 is DDR and we only count used lanes. */
-       csi2_ddrclk_khz = phy->external_rate / 1000
-               / (2 * num_lanes) * fmt->bpp;
-       phy_dbg(1, phy, "csi2_ddrclk_khz: %d\n", csi2_ddrclk_khz);
+       timeout = jiffies + msecs_to_jiffies(750);
+       while (time_before(jiffies, timeout)) {
+               if (reg_read_field(phy->cal,
+                                  CAL_CSI2_COMPLEXIO_CFG(phy->instance),
+                                  CAL_CSI2_COMPLEXIO_CFG_RESET_DONE_MASK) ==
+                   CAL_CSI2_COMPLEXIO_CFG_RESET_DONE_RESETCOMPLETED)
+                       break;
+               usleep_range(500, 5000);
+       }
 
-       /* THS_TERM: Programmed value = floor(20 ns/DDRClk period) */
-       ths_term = 20 * csi2_ddrclk_khz / 1000000;
-       phy_dbg(1, phy, "ths_term: %d (0x%02x)\n", ths_term, ths_term);
+       if (reg_read_field(phy->cal, CAL_CSI2_COMPLEXIO_CFG(phy->instance),
+                          CAL_CSI2_COMPLEXIO_CFG_RESET_DONE_MASK) !=
+                          CAL_CSI2_COMPLEXIO_CFG_RESET_DONE_RESETCOMPLETED)
+               phy_err(phy, "Timeout waiting for Complex IO reset done\n");
+}
 
-       /* THS_SETTLE: Programmed value = floor(105 ns/DDRClk period) + 4 */
-       ths_settle = (105 * csi2_ddrclk_khz / 1000000) + 4;
-       phy_dbg(1, phy, "ths_settle: %d (0x%02x)\n", ths_settle, ths_settle);
+static void cal_camerarx_wait_stop_state(struct cal_camerarx *phy)
+{
+       unsigned long timeout;
 
-       reg0 = reg_read(phy, CAL_CSI2_PHY_REG0);
-       set_field(&reg0, CAL_CSI2_PHY_REG0_HSCLOCKCONFIG_DISABLE,
-                 CAL_CSI2_PHY_REG0_HSCLOCKCONFIG_MASK);
-       set_field(&reg0, ths_term, CAL_CSI2_PHY_REG0_THS_TERM_MASK);
-       set_field(&reg0, ths_settle, CAL_CSI2_PHY_REG0_THS_SETTLE_MASK);
+       timeout = jiffies + msecs_to_jiffies(750);
+       while (time_before(jiffies, timeout)) {
+               if (reg_read_field(phy->cal,
+                                  CAL_CSI2_TIMING(phy->instance),
+                                  CAL_CSI2_TIMING_FORCE_RX_MODE_IO1_MASK) == 0)
+                       break;
+               usleep_range(500, 5000);
+       }
 
-       phy_dbg(1, phy, "CSI2_%d_REG0 = 0x%08x\n", phy->instance, reg0);
-       reg_write(phy, CAL_CSI2_PHY_REG0, reg0);
+       if (reg_read_field(phy->cal, CAL_CSI2_TIMING(phy->instance),
+                          CAL_CSI2_TIMING_FORCE_RX_MODE_IO1_MASK) != 0)
+               phy_err(phy, "Timeout waiting for stop state\n");
+}
 
-       reg1 = reg_read(phy, CAL_CSI2_PHY_REG1);
-       set_field(&reg1, TCLK_TERM, CAL_CSI2_PHY_REG1_TCLK_TERM_MASK);
-       set_field(&reg1, 0xb8, CAL_CSI2_PHY_REG1_DPHY_HS_SYNC_PATTERN_MASK);
-       set_field(&reg1, TCLK_MISS, CAL_CSI2_PHY_REG1_CTRLCLK_DIV_FACTOR_MASK);
-       set_field(&reg1, TCLK_SETTLE, CAL_CSI2_PHY_REG1_TCLK_SETTLE_MASK);
+static void cal_camerarx_wait_ready(struct cal_camerarx *phy)
+{
+       /* Steps
+        *  2. Wait for completion of reset
+        *          Note if the external sensor is not sending byte clock,
+        *          the reset will timeout
+        *  4.Force FORCERXMODE
+        *      G. Wait for all enabled lane to reach stop state
+        *      H. Disable pull down using pad control
+        */
 
-       phy_dbg(1, phy, "CSI2_%d_REG1 = 0x%08x\n", phy->instance, reg1);
-       reg_write(phy, CAL_CSI2_PHY_REG1, reg1);
+       /* 2. Wait for reset completion */
+       cal_camerarx_wait_reset(phy);
+
+       /* 4. G. Wait for all enabled lane to reach stop state */
+       cal_camerarx_wait_stop_state(phy);
+
+       phy_dbg(1, phy, "CSI2_%d_REG1 = 0x%08x (Bit(31,28) should be set!)\n",
+               phy->instance, reg_read(phy, CAL_CSI2_PHY_REG1));
 }
 
 static void cal_camerarx_init(struct cal_camerarx *phy,
@@ -734,65 +756,6 @@ static void cal_camerarx_init(struct cal_camerarx *phy,
        cal_camerarx_power(phy, true);
 }
 
-static void cal_camerarx_wait_reset(struct cal_camerarx *phy)
-{
-       unsigned long timeout;
-
-       timeout = jiffies + msecs_to_jiffies(750);
-       while (time_before(jiffies, timeout)) {
-               if (reg_read_field(phy->cal,
-                                  CAL_CSI2_COMPLEXIO_CFG(phy->instance),
-                                  CAL_CSI2_COMPLEXIO_CFG_RESET_DONE_MASK) ==
-                   CAL_CSI2_COMPLEXIO_CFG_RESET_DONE_RESETCOMPLETED)
-                       break;
-               usleep_range(500, 5000);
-       }
-
-       if (reg_read_field(phy->cal, CAL_CSI2_COMPLEXIO_CFG(phy->instance),
-                          CAL_CSI2_COMPLEXIO_CFG_RESET_DONE_MASK) !=
-                          CAL_CSI2_COMPLEXIO_CFG_RESET_DONE_RESETCOMPLETED)
-               phy_err(phy, "Timeout waiting for Complex IO reset done\n");
-}
-
-static void cal_camerarx_wait_stop_state(struct cal_camerarx *phy)
-{
-       unsigned long timeout;
-
-       timeout = jiffies + msecs_to_jiffies(750);
-       while (time_before(jiffies, timeout)) {
-               if (reg_read_field(phy->cal,
-                                  CAL_CSI2_TIMING(phy->instance),
-                                  CAL_CSI2_TIMING_FORCE_RX_MODE_IO1_MASK) == 0)
-                       break;
-               usleep_range(500, 5000);
-       }
-
-       if (reg_read_field(phy->cal, CAL_CSI2_TIMING(phy->instance),
-                          CAL_CSI2_TIMING_FORCE_RX_MODE_IO1_MASK) != 0)
-               phy_err(phy, "Timeout waiting for stop state\n");
-}
-
-static void cal_camerarx_wait_ready(struct cal_camerarx *phy)
-{
-       /* Steps
-        *  2. Wait for completion of reset
-        *          Note if the external sensor is not sending byte clock,
-        *          the reset will timeout
-        *  4.Force FORCERXMODE
-        *      G. Wait for all enabled lane to reach stop state
-        *      H. Disable pull down using pad control
-        */
-
-       /* 2. Wait for reset completion */
-       cal_camerarx_wait_reset(phy);
-
-       /* 4. G. Wait for all enabled lane to reach stop state */
-       cal_camerarx_wait_stop_state(phy);
-
-       phy_dbg(1, phy, "CSI2_%d_REG1 = 0x%08x (Bit(31,28) should be set!)\n",
-               phy->instance, reg_read(phy, CAL_CSI2_PHY_REG1));
-}
-
 static void cal_camerarx_deinit(struct cal_camerarx *phy)
 {
        unsigned int i;
@@ -822,32 +785,89 @@ static void cal_camerarx_deinit(struct cal_camerarx *phy)
        cal_camerarx_disable(phy);
 }
 
-static void cal_camerarx_lane_config(struct cal_camerarx *phy)
+/*
+ *   Errata i913: CSI2 LDO Needs to be disabled when module is powered on
+ *
+ *   Enabling CSI2 LDO shorts it to core supply. It is crucial the 2 CSI2
+ *   LDOs on the device are disabled if CSI-2 module is powered on
+ *   (0x4845 B304 | 0x4845 B384 [28:27] = 0x1) or in ULPS (0x4845 B304
+ *   | 0x4845 B384 [28:27] = 0x2) mode. Common concerns include: high
+ *   current draw on the module supply in active mode.
+ *
+ *   Errata does not apply when CSI-2 module is powered off
+ *   (0x4845 B304 | 0x4845 B384 [28:27] = 0x0).
+ *
+ * SW Workaround:
+ *     Set the following register bits to disable the LDO,
+ *     which is essentially CSI2 REG10 bit 6:
+ *
+ *             Core 0:  0x4845 B828 = 0x0000 0040
+ *             Core 1:  0x4845 B928 = 0x0000 0040
+ */
+static void cal_camerarx_i913_errata(struct cal_camerarx *phy)
 {
-       u32 val = reg_read(phy->cal, CAL_CSI2_COMPLEXIO_CFG(phy->instance));
-       u32 lane_mask = CAL_CSI2_COMPLEXIO_CFG_CLOCK_POSITION_MASK;
-       u32 polarity_mask = CAL_CSI2_COMPLEXIO_CFG_CLOCK_POL_MASK;
-       struct v4l2_fwnode_bus_mipi_csi2 *mipi_csi2 =
-               &phy->endpoint.bus.mipi_csi2;
-       int lane;
+       u32 reg10 = reg_read(phy, CAL_CSI2_PHY_REG10);
 
-       set_field(&val, mipi_csi2->clock_lane + 1, lane_mask);
-       set_field(&val, mipi_csi2->lane_polarities[0], polarity_mask);
-       for (lane = 0; lane < mipi_csi2->num_data_lanes; lane++) {
-               /*
-                * Every lane are one nibble apart starting with the
-                * clock followed by the data lanes so shift masks by 4.
-                */
-               lane_mask <<= 4;
-               polarity_mask <<= 4;
-               set_field(&val, mipi_csi2->data_lanes[lane] + 1, lane_mask);
-               set_field(&val, mipi_csi2->lane_polarities[lane + 1],
-                         polarity_mask);
-       }
+       set_field(&reg10, 1, CAL_CSI2_PHY_REG10_I933_LDO_DISABLE_MASK);
 
-       reg_write(phy->cal, CAL_CSI2_COMPLEXIO_CFG(phy->instance), val);
-       phy_dbg(3, phy, "CAL_CSI2_COMPLEXIO_CFG(%d) = 0x%08x\n",
-               phy->instance, val);
+       phy_dbg(1, phy, "CSI2_%d_REG10 = 0x%08x\n", phy->instance, reg10);
+       reg_write(phy, CAL_CSI2_PHY_REG10, reg10);
+}
+
+/*
+ * Enable the expected IRQ sources
+ */
+static void cal_camerarx_enable_irqs(struct cal_camerarx *phy)
+{
+       u32 val;
+
+       const u32 cio_err_mask =
+               CAL_CSI2_COMPLEXIO_IRQ_LANE_ERRORS_MASK |
+               CAL_CSI2_COMPLEXIO_IRQ_FIFO_OVR_MASK |
+               CAL_CSI2_COMPLEXIO_IRQ_SHORT_PACKET_MASK |
+               CAL_CSI2_COMPLEXIO_IRQ_ECC_NO_CORRECTION_MASK;
+
+       /* Enable CIO error irqs */
+       reg_write(phy->cal, CAL_HL_IRQENABLE_SET(0),
+                 CAL_HL_IRQ_CIO_MASK(phy->instance));
+       reg_write(phy->cal, CAL_CSI2_COMPLEXIO_IRQENABLE(phy->instance),
+                 cio_err_mask);
+
+       /* Always enable OCPO error */
+       reg_write(phy->cal, CAL_HL_IRQENABLE_SET(0), CAL_HL_IRQ_OCPO_ERR_MASK);
+
+       /* Enable IRQ_WDMA_END 0/1 */
+       val = 0;
+       set_field(&val, 1, CAL_HL_IRQ_MASK(phy->instance));
+       reg_write(phy->cal, CAL_HL_IRQENABLE_SET(1), val);
+       /* Enable IRQ_WDMA_START 0/1 */
+       val = 0;
+       set_field(&val, 1, CAL_HL_IRQ_MASK(phy->instance));
+       reg_write(phy->cal, CAL_HL_IRQENABLE_SET(2), val);
+       /* Todo: Add VC_IRQ and CSI2_COMPLEXIO_IRQ handling */
+       reg_write(phy->cal, CAL_CSI2_VC_IRQENABLE(0), 0xFF000000);
+}
+
+static void cal_camerarx_disable_irqs(struct cal_camerarx *phy)
+{
+       u32 val;
+
+       /* Disable CIO error irqs */
+       reg_write(phy->cal, CAL_HL_IRQENABLE_CLR(0),
+                 CAL_HL_IRQ_CIO_MASK(phy->instance));
+       reg_write(phy->cal, CAL_CSI2_COMPLEXIO_IRQENABLE(phy->instance),
+                 0);
+
+       /* Disable IRQ_WDMA_END 0/1 */
+       val = 0;
+       set_field(&val, 1, CAL_HL_IRQ_MASK(phy->instance));
+       reg_write(phy->cal, CAL_HL_IRQENABLE_CLR(1), val);
+       /* Disable IRQ_WDMA_START 0/1 */
+       val = 0;
+       set_field(&val, 1, CAL_HL_IRQ_MASK(phy->instance));
+       reg_write(phy->cal, CAL_HL_IRQENABLE_CLR(2), val);
+       /* Todo: Add VC_IRQ and CSI2_COMPLEXIO_IRQ handling */
+       reg_write(phy->cal, CAL_CSI2_VC_IRQENABLE(0), 0);
 }
 
 static void cal_camerarx_ppi_enable(struct cal_camerarx *phy)
@@ -863,26 +883,6 @@ static void cal_camerarx_ppi_disable(struct cal_camerarx *phy)
                        0, CAL_CSI2_PPI_CTRL_IF_EN_MASK);
 }
 
-static int cal_camerarx_get_external_info(struct cal_camerarx *phy)
-{
-       struct v4l2_ctrl *ctrl;
-
-       if (!phy->sensor)
-               return -ENODEV;
-
-       ctrl = v4l2_ctrl_find(phy->sensor->ctrl_handler, V4L2_CID_PIXEL_RATE);
-       if (!ctrl) {
-               phy_err(phy, "no pixel rate control in subdev: %s\n",
-                       phy->sensor->name);
-               return -EPIPE;
-       }
-
-       phy->external_rate = v4l2_ctrl_g_ctrl_int64(ctrl);
-       phy_dbg(3, phy, "sensor Pixel Rate: %u\n", phy->external_rate);
-
-       return 0;
-}
-
 static int cal_camerarx_regmap_init(struct cal_dev *cal,
                                    struct cal_camerarx *phy)
 {