]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
gpio: pca953x: Use bitmap API over implicit GCC extension
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Wed, 30 Sep 2020 14:20:12 +0000 (17:20 +0300)
committerLinus Walleij <linus.walleij@linaro.org>
Thu, 1 Oct 2020 08:00:17 +0000 (10:00 +0200)
In IRQ handler we have to clear bitmap before use. Currently
the GCC extension has been used for that. For sake of the consistency
switch to bitmap API. As expected bloat-o-meter shows no difference
in the object size.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Link: https://lore.kernel.org/r/20200930142013.59247-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpio-pca953x.c

index 29342e5def82bd74455a903f494d207fddca8c48..7f64e69485747aba8f7bbee80011d945f0d4dad2 100644 (file)
@@ -814,10 +814,12 @@ static irqreturn_t pca953x_irq_handler(int irq, void *devid)
 {
        struct pca953x_chip *chip = devid;
        struct gpio_chip *gc = &chip->gpio_chip;
-       DECLARE_BITMAP(pending, MAX_LINE) = {};
+       DECLARE_BITMAP(pending, MAX_LINE);
        int level;
        bool ret;
 
+       bitmap_zero(pending, MAX_LINE);
+
        mutex_lock(&chip->i2c_lock);
        ret = pca953x_irq_pending(chip, pending);
        mutex_unlock(&chip->i2c_lock);